Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix duplicated service names in metrics metadata #184

Merged
merged 2 commits into from
Apr 15, 2021
Merged

fix: Fix duplicated service names in metrics metadata #184

merged 2 commits into from
Apr 15, 2021

Conversation

andrzej-stencel
Copy link
Contributor

@andrzej-stencel andrzej-stencel commented Apr 15, 2021 •
edited
Loading

Fixes #186

@andrzej-stencel andrzej-stencel requested a review from a team as a code owner April 15, 2021 13:51
pmalek-sumo
pmalek-sumo reviewed Apr 15, 2021
View reviewed changes
Copy link
Contributor

@pmalek-sumo pmalek-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests 😿 ?

@andrzej-stencel andrzej-stencel force-pushed the fix-duplicate-service-names branch from a3da988 to 8e6ec10 Compare April 15, 2021 14:30
@andrzej-stencel
Copy link
Contributor Author

tests 😿 ?

Added tests, thanks for reminding me! 💡

@andrzej-stencel andrzej-stencel force-pushed the fix-duplicate-service-names branch from 8e6ec10 to 7659528 Compare April 15, 2021 14:43
pmalek-sumo
pmalek-sumo reviewed Apr 15, 2021
View reviewed changes
Copy link
Contributor

@pmalek-sumo pmalek-sumo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm cool with this PR, the only nit I have is to add a short description under which circumstances it did happen before your fix here.

I presume when there were more than 1 endpoint for a pod/service?

@andrzej-stencel
Copy link
Contributor Author

andrzej-stencel commented Apr 15, 2021 •
edited
Loading

I'm cool with this PR, the only nit I have is to add a short description under which circumstances it did happen before your fix here.

I presume when there were more than 1 endpoint for a pod/service?

Yeah I thought about this. Maybe I should create an issue describing the circumstances and link the PR to it?

EDIT: Created issue #186 and linked to this PR.

@andrzej-stencel andrzej-stencel changed the title fix: Duplicated service names in metrics metadata fix: Fix duplicated service names in metrics metadata Apr 15, 2021
@andrzej-stencel andrzej-stencel merged commit 2d2b769 into main Apr 15, 2021
@andrzej-stencel andrzej-stencel deleted the fix-duplicate-service-names branch April 15, 2021 15:22
This was referenced Apr 16, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmalek-sumo pmalek-sumo pmalek-sumo approved these changes

@perk-sumo perk-sumo perk-sumo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Metrics service dimension contains duplicated names
3 participants
@andrzej-stencel @perk-sumo @pmalek-sumo