feat(sumologicexporter): allows ., /, : and _ for prometheus key
#211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmalek-sumo
approved these changes
Sep 13, 2021
sumo-drosiek
force-pushed
the
drosiek-extend-allowed-chars-for-prometheus-format
branch
from
aeecd6b
to
4af33f2
Compare
Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
sumo-drosiek
force-pushed
the
drosiek-extend-allowed-chars-for-prometheus-format
branch
from
4af33f2
to
b794892
Compare
sumo-drosiek
changed the title
. and / for prometheus key., /, : and _ for prometheus key
|
@kkujawa-sumo it should solve issue with label names: Fluentd: |
sumo-drosiek
deleted the
drosiek-extend-allowed-chars-for-prometheus-format
branch
mx-psi
pushed a commit
to open-telemetry/opentelemetry-collector-contrib
that referenced
this pull request
Apr 23, 2024
…32595) **Description:** Use new formatter for prometheus, which fixes metric name sanitization. This also refactors the formatter itself, which is part of #31479 and reduces size of #32315 **Link to tracking Issue:** Applies SumoLogic/sumologic-otel-collector#211 and more, but this one is a bug fix **Testing:** Unit tests **Documentation:** N/A --------- Signed-off-by: Dominik Rosiek <drosiek@sumologic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow
.and/for prometheus keySigned-off-by: Dominik Rosiek drosiek@sumologic.com