-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sumologicexporter): don't send null logs #236
Conversation
a258b33
to
7303bbf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can the test case with sending null logs be added to unit tests? If yes, I recommend to add this.
I wanted to do this but it seems that it's non trivial to make the exporter send the empty logs due to logic in I'm open to ideas to actually add a test for that. ref: sumologic-otel-collector/pkg/exporter/sumologicexporter/sender.go Lines 400 to 438 in 2a5baaa
|
76e03f6
to
9690129
Compare
9690129
to
0dd4536
Compare
To prevent sending
null
logs check if the body is not empty before attaching it like in the attached screenshot: