-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve Technical Debt- Upgrade from JDK-8 to JDK21 and Spring Boot from 2.3.12.RELEASE to 3.3.2 #346
base: main
Are you sure you want to change the base?
Conversation
…ized version numbers. Fixed few code quality issues.
…ed unwanted test case.
…ed unwanted test case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixed all functional test scenarios with sync scope in karate-test-cases |
.anyMatch(requestUri::matches)) { | ||
servletRequest.getRequestDispatcher(((HttpServletRequest) servletRequest).getServletPath()).forward(servletRequest, servletResponse); | ||
servletRequest.getRequestDispatcher(servletRequest.getServletPath()).forward(servletRequest, servletResponse); |
Check failure
Code scanning / CodeQL
URL forward from a remote source High
user-provided value
.map(d -> String.format("/api/v1/%s([^/]+)?(((\\?)|(\\%s)).*)?", d, "%3F")) | ||
.anyMatch(requestUri::matches)) { | ||
logger.debug("Forwarded NON Invite and Anonymous to : {} anonymousSchemas {} ", servletRequest.getServletPath(), anonymousSchemas); | ||
servletRequest.getRequestDispatcher(servletRequest.getServletPath()).forward(servletRequest, servletResponse); |
Check failure
Code scanning / CodeQL
URL forward from a remote source High
user-provided value
public SecurityFilterChain securityFilterChain(HttpSecurity http) throws Exception { | ||
Map<String, AuthenticationManager> authenticationManagers = new HashMap<>(); | ||
oAuth2Configuration.getResources().forEach(issuer -> addManager(authenticationManagers, issuer)); | ||
http.csrf(AbstractHttpConfigurer::disable) |
Check failure
Code scanning / CodeQL
Disabled Spring CSRF protection High
The build is failing because the projects under services did not receive JDK upgrade. |
RFC: Resolve Technical Debt of JDK and Spring Boot in Sunbird-RC-core #1053
This PR has changes needed to address the technical debt described in #1053
Following is the summary of changes