PERF: Make AdvancedNormalizedCorrelationImageToImageMetric faster #556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a new member function to `AdvancedImageToImageMetric`, `FastEvaluateMovingImageValueAndDerivative`, which calls the multi-threaded overload of ITK's `itk::BSplineInterpolateImageFunction::EvaluateValueAndDerivativeAtContinuousIndex`, indirectly. (It does so via `EvaluateMovingImageValueAndDerivativeWithOptionalThreadId`, another new member function.) Made `AdvancedNormalizedCorrelationImageToImageMetric::ThreadedGetValueAndDerivative` faster, by calling this new `FastEvaluateMovingImageValueAndDerivative`. A large performance improvement was observed for GoogleTest unit test `itkElastixRegistrationMethod.EulerDiscRotation2D` (which uses the "AdvancedNormalizedCorrelation" metric), from ~1.5 second before this commit down to ~0.9 second after this commit, using Visual Studio 2019, Release configuration. (For a Debug configuration even from ~15 seconds before, down to ~4 seconds after this commit.)
|
@mstaring @stefanklein Here is the "Slower, but safer" Here is the faster overload (which has a "FIXME -- Review this "fix" and ensure it works." The performance improvement comes from skipping the memory allocation of local For the record, the "FIXME" was there already with commit InsightSoftwareConsortium/ITK@6abbc79 (6 August 2010): https://github.com/InsightSoftwareConsortium/ITK/blob/6abbc7969a90786c4c73f5d191f634db536c2d1d/Code/BasicFilters/itkBSplineInterpolateImageFunction.txx#L297 |
N-Dekker
added a commit
that referenced
this pull request
Nov 27, 2021
Replace `this->EvaluateMovingImageValueAndDerivative(...)` calls by `this->FastEvaluateMovingImageValueAndDerivative(..., threadId)` in four more metrics: itkAdvancedKappaStatisticImageToImageMetric itkParzenWindowMutualInformationImageToImageMetric itkAdvancedMeanSquaresImageToImageMetric itkPCAMetric_F_multithreaded Follow-up to pull request #556 commit c8c4a6a "PERF: Make AdvancedNormalizedCorrelationImageToImageMetric faster"
N-Dekker
added a commit
that referenced
this pull request
Nov 27, 2021
Replace `this->EvaluateMovingImageValueAndDerivative(...)` calls by `this->FastEvaluateMovingImageValueAndDerivative(..., threadId)` in the "Threaded" member functions of six more metrics:
itkAdvancedKappaStatisticImageToImageMetric
itkAdvancedMeanSquaresImageToImageMetric
itkParzenWindowHistogramImageToImageMetric
itkParzenWindowMutualInformationImageToImageMetric
itkPCAMetric_F_multithreaded
itkSumSquaredTissueVolumeDifferenceImageToImageMetric
Expected a significant performance gain on the run-time duration.
Follow-up to pull request #556 commit c8c4a6a "PERF: Make AdvancedNormalizedCorrelationImageToImageMetric faster"
N-Dekker
added a commit
that referenced
this pull request
Nov 27, 2021
Replace `this->EvaluateMovingImageValueAndDerivative(...)` calls by `this->FastEvaluateMovingImageValueAndDerivative(..., threadId)` in the "Threaded" member functions of six more metrics:
itkAdvancedKappaStatisticImageToImageMetric
itkAdvancedMeanSquaresImageToImageMetric
itkParzenWindowHistogramImageToImageMetric
itkParzenWindowMutualInformationImageToImageMetric
itkPCAMetric_F_multithreaded
itkSumSquaredTissueVolumeDifferenceImageToImageMetric
Expected a significant performance gain on the run-time duration.
Follow-up to pull request #556 commit c8c4a6a "PERF: Make AdvancedNormalizedCorrelationImageToImageMetric faster"
N-Dekker
added a commit
that referenced
this pull request
Nov 27, 2021
Replaced `this->EvaluateMovingImageValueAndDerivative(...)` calls by `this->FastEvaluateMovingImageValueAndDerivative(..., threadId)` in the "Threaded" member functions of six more metrics:
itkAdvancedKappaStatisticImageToImageMetric
itkAdvancedMeanSquaresImageToImageMetric
itkParzenWindowHistogramImageToImageMetric
itkParzenWindowMutualInformationImageToImageMetric
itkPCAMetric_F_multithreaded
itkSumSquaredTissueVolumeDifferenceImageToImageMetric
Expected a significant performance gain on the run-time duration.
`AdvancedKappaStatisticImageToImageMetric::ThreadedGetValueAndDerivative` is being tested by 55/161 - elastix_run_3DCT_lung.Kappa.bspline.ASGD.001_OUTPUT
`AdvancedMeanSquaresImageToImageMetric::ThreadedGetValueAndDerivative` is being tested by:
- 43/161 - elastix_run_3DCT_lung.SSD.bspline.ASGD.001_OUTPUT
- 98/161 - elastix_run_3DCT_lung.SSD.bspline.ASGD.002_OUTPUT
- 102/161 - elastix_run_3DCT_lung.SSD.bspline.ASGD.003_OUTPUT
- 106/161 - elastix_run_3DCT_lung.SSD.bspline.ASGD.001-Threads1_OUTPUT
- 110/161 - elastix_run_3DCT_lung.SSD.bspline.ASGD.001-Threads2_OUTPUT
- 114/161 - elastix_run_3DCT_lung.SSD.bspline.ASGD.001-Threads4_OUTPUT
`ParzenWindowHistogramImageToImageMetric::ThreadedComputePDFs` is being tested by:
- 20/161 - elastix_run_example_OUTPUT
- 47/161 - elastix_run_3DCT_lung.MI.bspline.ASGD.001_OUTPUT
- 82/161 - elastix_run_3DCT_lung.MI.bspline.SGD.001_OUTPUT
- 86/161 - elastix_run_3DCT_lung.MI.bspline.SGD.002_OUTPUT
- 90/161 - elastix_run_3DCT_lung.MI.bspline.SGD.003_OUTPUT
- 94/161 - elastix_run_3DCT_lung.MI.bspline.SGD.004_OUTPUT
- 130/161 - elastix_run_3DCT_lung.MI.bspline.SGD.001-Threads1_OUTPUT
- 134/161 - elastix_run_3DCT_lung.MI.bspline.SGD.001-Threads2_OUTPUT
- 138/161 - elastix_run_3DCT_lung.MI.bspline.SGD.001-Threads4_OUTPUT
Follow-up to pull request #556 commit c8c4a6a "PERF: Make AdvancedNormalizedCorrelationImageToImageMetric faster"
N-Dekker
added a commit
that referenced
this pull request
Nov 28, 2021
Replaced `this->EvaluateMovingImageValueAndDerivative(...)` calls by `this->FastEvaluateMovingImageValueAndDerivative(..., threadId)` in the "Threaded" member functions of six more metrics:
itkAdvancedKappaStatisticImageToImageMetric
itkAdvancedMeanSquaresImageToImageMetric
itkParzenWindowHistogramImageToImageMetric
itkParzenWindowMutualInformationImageToImageMetric
itkPCAMetric_F_multithreaded
itkSumSquaredTissueVolumeDifferenceImageToImageMetric
Expected a significant performance gain on the run-time duration.
`AdvancedKappaStatisticImageToImageMetric::ThreadedGetValueAndDerivative` is being tested by 55/161 - elastix_run_3DCT_lung.Kappa.bspline.ASGD.001_OUTPUT
`AdvancedMeanSquaresImageToImageMetric::ThreadedGetValueAndDerivative` is being tested by:
- 43/161 - elastix_run_3DCT_lung.SSD.bspline.ASGD.001_OUTPUT
- 98/161 - elastix_run_3DCT_lung.SSD.bspline.ASGD.002_OUTPUT
- 102/161 - elastix_run_3DCT_lung.SSD.bspline.ASGD.003_OUTPUT
- 106/161 - elastix_run_3DCT_lung.SSD.bspline.ASGD.001-Threads1_OUTPUT
- 110/161 - elastix_run_3DCT_lung.SSD.bspline.ASGD.001-Threads2_OUTPUT
- 114/161 - elastix_run_3DCT_lung.SSD.bspline.ASGD.001-Threads4_OUTPUT
`ParzenWindowHistogramImageToImageMetric::ThreadedComputePDFs` is being tested by:
- 20/161 - elastix_run_example_OUTPUT
- 47/161 - elastix_run_3DCT_lung.MI.bspline.ASGD.001_OUTPUT
- 82/161 - elastix_run_3DCT_lung.MI.bspline.SGD.001_OUTPUT
- 86/161 - elastix_run_3DCT_lung.MI.bspline.SGD.002_OUTPUT
- 90/161 - elastix_run_3DCT_lung.MI.bspline.SGD.003_OUTPUT
- 94/161 - elastix_run_3DCT_lung.MI.bspline.SGD.004_OUTPUT
- 130/161 - elastix_run_3DCT_lung.MI.bspline.SGD.001-Threads1_OUTPUT
- 134/161 - elastix_run_3DCT_lung.MI.bspline.SGD.001-Threads2_OUTPUT
- 138/161 - elastix_run_3DCT_lung.MI.bspline.SGD.001-Threads4_OUTPUT
Follow-up to pull request #556 commit c8c4a6a "PERF: Make AdvancedNormalizedCorrelationImageToImageMetric faster"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new member function to
AdvancedImageToImageMetric,FastEvaluateMovingImageValueAndDerivative, which calls the multi-threaded overload of ITK'sitk::BSplineInterpolateImageFunction::EvaluateValueAndDerivativeAtContinuousIndex, indirectly. (It does so viaEvaluateMovingImageValueAndDerivativeWithOptionalThreadId, another new member function.)Made
AdvancedNormalizedCorrelationImageToImageMetric::ThreadedGetValueAndDerivativefaster, by calling this newFastEvaluateMovingImageValueAndDerivative.A large performance improvement was observed for GoogleTest unit test
itkElastixRegistrationMethod.EulerDiscRotation2D(which uses the "AdvancedNormalizedCorrelation" metric), from ~1.5 second before this commit down to ~0.9 second after this commit, using Visual Studio 2019, Release configuration. (For a Debug configuration even from ~15 seconds before, down to ~4 seconds after this commit.)