Take host label from the pinger for consistency #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Older versions of pro-bing return the host name as pkt.Addr but newer versions return the stringified version of IPAddr instead. Signed-off-by: Tom Hughes <tom@compton.nu>
tomhughes
added a commit
to openstreetmap/prometheus-exporters
that referenced
this pull request
Mar 10, 2024
|
Hmm, I wonder if we should fix this upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The update of pro-bing from 0.3.0 to 0.4.0 in #140 pulled in prometheus-community/pro-bing#65 which has changed the meaning of
pkt.Addrand causes metrics to be recorded with the IP address as both the host and ip labels.This causes mismatches with the request metric which still has the host name, and duplicate response metrics as the initial ones are added with the correct host label (but never increment) while the callbacks created duplicate metrics with the IP address as the host label.
This change ensures that the host name from the pinger is used consistently when recording metrics.