Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTPS support #69

Merged
merged 1 commit into from
May 23, 2022
Merged

Add HTTPS support #69

merged 1 commit into from
May 23, 2022

Conversation

yuriykis
Copy link
Contributor

@yuriykis yuriykis commented May 6, 2022

Hi, just added the ability to run the exporter on the HTTPS server. If it's better to do it some other way, please let me know

@SuperQ
Copy link
Owner

SuperQ commented May 6, 2022

This should be done with the exporter-toolkit.

main.go Outdated Show resolved Hide resolved
@SuperQ
Copy link
Owner

SuperQ commented May 23, 2022

This needs a DCO sign-off. You can use git commit -s --amend to add it.

Please also squash the commits.

Signed-off-by: Yuriy Kis <yurakis9@gmail.com>

Add HTTPS support

Signed-off-by: Yuriy Kis <yurakis9@gmail.com>

Add tls config to README

Signed-off-by: Yuriy Kis <yurakis9@gmail.com>

Remove unnecessary params from target group

Signed-off-by: Yuriy Kis <yurakis9@gmail.com>
@yuriykis
Copy link
Contributor Author

Squashed commits and added DCO sign-off

Copy link
Owner

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

config/config.go Outdated Show resolved Hide resolved
@SuperQ SuperQ merged commit 0a61796 into SuperQ:master May 23, 2022
SuperQ added a commit that referenced this pull request May 23, 2022
* [CHANGE] Exit with a non-zero error code on fatal error #70
* [FEATURE] Add TLS/Auth from exporter-toolkit #69

Misc:
* Update build to Go 1.18.
* Bump Go modules.
* Enable dependabot.
* Sync upstream Prometheus Makefile.common.

Signed-off-by: SuperQ <superq@gmail.com>
@SuperQ SuperQ mentioned this pull request May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants