Refactor AmbientSound (#2688)

Implements new SoundObject object that is hearable in entire Sector. It is possible to change it's volume and looping sound play interval. Attempts to fix the long-broken AmbientSound.

Co-authored-by: Rusty-Box <carstenwirtz@​live.de

data/images/engine/editor/objects.stoi

@@ -356,24 +356,21 @@
   (object
     (class "particles-ghosts")
     (icon "images/engine/editor/ghostparticles.png"))
-
-
-
 ;;  +-- This should be disabled, as it probably won't support multiple textures
 ;;  |   per config object.
 ;;  v                               ~ Semphris
   (object
     (class "particles-custom")
     (icon "images/engine/editor/particle.png"))
-
-
-
   (object
     (class "particles-custom-file")
     (icon "images/engine/editor/particle_file.png"))
   (object
     (class "textscroller")
     (icon "images/engine/editor/textscroller.png"))
+  (object
+    (class "sound-object")
+    (icon "images/engine/editor/sound.png"))
  )
 
  (objectgroup

src/audio/dummy_sound_source.cpp

@@ -34,7 +34,7 @@ class DummySoundSource final : public SoundSource
     is_playing = true;
   }
 
-  virtual void stop() override
+  virtual void stop(bool) override
   {
     is_playing = false;
   }

src/audio/openal_sound_source.cpp

@@ -40,15 +40,16 @@ OpenALSoundSource::~OpenALSoundSource()
 }
 
 void
-OpenALSoundSource::stop()
+OpenALSoundSource::stop(bool unload_buffer)
 {
 #ifdef WIN32
   // See commit 417a8e7a8c599bfc2dceaec7b6f64ac865318ef1
   alSourceRewindv(1, &m_source); // Stops the source
 #else
   alSourceStop(m_source);
 #endif
-  alSourcei(m_source, AL_BUFFER, AL_NONE);
+  if (unload_buffer)
+    alSourcei(m_source, AL_BUFFER, AL_NONE);
   try
   {
     SoundManager::check_al_error("Problem stopping audio source: ");

src/audio/openal_sound_source.hpp

@@ -30,7 +30,7 @@ class OpenALSoundSource : public SoundSource
   ~OpenALSoundSource() override;
 
   virtual void play() override;
-  virtual void stop() override;
+  virtual void stop(bool unload_buffer = true) override;
   virtual bool playing() const override;
 
   virtual void set_looping(bool looping) override;

src/audio/sound_source.hpp

@@ -29,7 +29,7 @@ class SoundSource
   virtual ~SoundSource() {}
 
   virtual void play() = 0;
-  virtual void stop() = 0;
+  virtual void stop(bool unload_buffer = true) = 0;
   virtual bool playing() const = 0;
 
   virtual void set_looping(bool looping) = 0;