Refactor Player.cpp #3116
Draft
Refactor Player.cpp #3116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 29, 2024 03:51
This exposes some Squirrel methods such as set_sprite. Pretty fun. Big tux is still jank but this may be somewhere in the file.
|
I think this pr is cool . |
swagtoy
force-pushed
the
player-refactor
branch
from
83cb6a1 to
230b867
Compare
|
Unrelated note but kind of surprised git doesnt allow for true commit renaming in 2024 because "Oh no" was not a good commit message and force pushing is not a great decision |
added 5 commits
December 3, 2024 01:28
|
State machine code is done, though right now, MovingSprite has broken Tux's logic (still looking into why) but its likely due to disgusting jank code... but anyone is welcome to take a look at this right now and note any thoughts (overall code still sucks ass). You can use squirrel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About damn time.
Highlights:
Tux.set_spritecalls and have fun with that. Custom sprites are possible now. This was so easy to do it hurts.Main things on my bucketlist are refactoring the majority of state into either a) their own smaller classes, b) into more functions, and c) maybe bitwise state and/or std::bitset. The input code is kind of disgusting and could be set up some. State machinery stuff related to switching the players sprite likely has room for improvement. Update function is just putrid. Input/shooting/powerup code MIGHT be able to get refactored out of player, i'll see what I can do :)