Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event's identifiers are based on the naming of the storage structure #2

Open
xgreenx opened this issue Jun 7, 2021 · 1 comment
Open
Assignees
Labels
blocker It means that issue is blocker for production

Comments

@xgreenx
Copy link
Contributor

xgreenx commented Jun 7, 2021

The naming of the storage structure affects event identifiers.
It means that if users are implementing the same interface, events provided by them can have different identifiers(and topics of this event too) in case of the different storage struct naming.

The solution for this can be: during the definition of events set the name of the trait which will emit these events. In this case, if users implement the IErc20 trait, events emitted by them will have the same identifiers.
But this solutions is not possible at the moment for 2 reasons:

  1. We can't define events during trait definition. It is described here
  2. Event doesn't allow to customize ident of storage struct/trait. But it can be easily integrated.

Also it can be part of use-ink/ink#564

@xgreenx xgreenx added the blocker It means that issue is blocker for production label Jun 7, 2021
@xgreenx xgreenx self-assigned this Jun 7, 2021
@xgreenx
Copy link
Contributor Author

xgreenx commented Jun 8, 2021

Resolving of use-ink/ink#809 will resolve our issue.

coreggon11 added a commit that referenced this issue Oct 28, 2021
coreggon11 added a commit that referenced this issue Oct 29, 2021
coreggon11 added a commit that referenced this issue Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker It means that issue is blocker for production
Projects
None yet
Development

No branches or pull requests

1 participant