Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash at system time change back #281

Closed
lifsong opened this issue Aug 18, 2013 · 1 comment
Closed

Crash at system time change back #281

lifsong opened this issue Aug 18, 2013 · 1 comment

Comments

@lifsong
Copy link

lifsong commented Aug 18, 2013

There's a reproduce path to make supervisord crash:

  1. set system time 1 year before real time.
  2. killall one_program_under_supervisoring.
  3. you'll see supervisord crashed.

Checked the code and see that our process state calculation depends a lot on system time. System time change may cause assertion.

mook-as pushed a commit to mook-as/supervisor that referenced this issue Jul 21, 2014
This makes sure system time changes (e.g. via ntp) doesn't result in odd
assertion failures due to processes entering the running state before being
started.

Supervisor#281
https://bugs.activestate.com/show_bug.cgi?id=104508
https://activestate.atlassian.net/browse/STO-859
mook-as pushed a commit to hpcloud/supervisor that referenced this issue Jul 22, 2014
This makes sure system time changes (e.g. via ntp) doesn't result in odd
assertion failures due to processes entering the running state before being
started.

Supervisor#281
Supervisor#468
https://bugs.activestate.com/show_bug.cgi?id=104508
https://activestate.atlassian.net/browse/STO-859
@lonetwin
Copy link

Just adding a me-too here. We ran into this problem when running supervisord within a vmware instance which had an option set which would sync the guest's time with the host's. This would cause problems when the host was under load or the time ^jumped back^ due to ntp. If we then would kill one of the processes in the guest running under the supervisor instance on the guest, supervisor would die and orphan all the rest of the processes. I can confirm that this patch appears to stop supervisor from crashing.

mnaberez added a commit that referenced this issue Aug 8, 2015
mnaberez added a commit that referenced this issue Nov 4, 2015
mnaberez added a commit that referenced this issue Nov 8, 2015
alexsilva pushed a commit to alexsilva/supervisor that referenced this issue Jun 21, 2019
alexsilva pushed a commit to alexsilva/supervisor that referenced this issue Jun 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants