Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix enforce protection logic #30

Merged
merged 2 commits into from
Feb 18, 2021
Merged

Fix enforce protection logic #30

merged 2 commits into from
Feb 18, 2021

Conversation

SvanBoxel
Copy link
Owner

At the moment the app copies all current required status checks as an array and then, depending on whether you enforce it or not, adds a new required check to that array. That means that even though you toggle the boolean from true to false, it will still be part of the original array of required checks.

This PR:

  • Removes the context from the required contexts array if it is un-enforced
  • Adds specs for the enforce-protections function

Fixes #24

@SvanBoxel SvanBoxel merged commit a2be6d2 into main Feb 18, 2021
@SvanBoxel
Copy link
Owner Author

Release with 1.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Un-enforcing status check doesn't work as expected
1 participant