Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allowing more extensibility to customize the mqtt events logged in the database #173

Merged
merged 5 commits into from
Feb 20, 2024

Conversation

ionutab
Copy link
Contributor

@ionutab ionutab commented Feb 20, 2024

Added this to allow the option for users to customize the events logged in the database.
This would be done by extending the MqttClient class and overriding the _generate_event_name method.
For example when sending messages on a large variety of topics this generates a very fuzzy and hard-to-read set of charts in Grafana.
A more generic, simple view may be required.
Altering the queries in the Grafana dashboards to simplify the charts can be error-prone, performance downgrading, and will create maintenance overhead.
This solution allows users to alter the logged entry in the database for a more use-case-centric grouping.
I can provide more details of required - like a very simple dataset.
Thank you

@cyberw
Copy link
Collaborator

cyberw commented Feb 20, 2024

Lgtm, but could you add an example of how to use it? In mqtt_ex.py or a separate one.

@ionutab
Copy link
Contributor Author

ionutab commented Feb 20, 2024

sure thing,
after I fix the linting issue

@cyberw cyberw merged commit c7d79ca into SvenskaSpel:master Feb 20, 2024
7 checks passed
@ionutab
Copy link
Contributor Author

ionutab commented Feb 20, 2024

@cyberw thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants