[STK-233][FIX] - Bug in UI order amount calcs #171
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
berteotti
reviewed
Apr 5, 2024
Comment on lines
+592
to
+594
| isPastStartDate | ||
| ? new Date(getDatePlus10Mins(startDateTime)) | ||
| : startDateTime |
There was a problem hiding this comment.
This will not work if the user chooses the current date and hour and then only submits the tx 15 minutes after. This will be 5 minutes in the past and tx will fail.
|
This PR is being slate for a while. We should finish it or close it. |
release: v1.3.0
* improve arbitrum token list assets with better custom images (#179) - gmx - uni - compound * show complete bar on orders when all funds are used (#181) * [fix] replace yarn with bun (#180) * Simplify confirm stack (#182) * - simplify confirm modal * - show TX instead of transaction on orders table on mobile * - rename StackInfo to StackDigest - Move StackDigest above orders * refactor StackModal - extract StackFrequencyAndDates - Rename StackOrdersProgress and move related orders componentd there * update github action node, bun versions * 1.3.1
ElRodrigote
force-pushed
the
fix/stk-233-bug-in-ui-order-amount-calcs
branch
from
f87f539 to
ceb46cb
Compare
Deploying stackly-ui with
|
| Latest commit: |
ceb46cb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://98b2d971.stackly-ui.pages.dev |
| Branch Preview URL: | https://fix-stk-233-bug-in-ui-order.stackly-ui.pages.dev |
|
Closing this PR to re-do it after being a long time in Draft |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: STK-233
Description
How to test the changes