[STK-233][FIX] - Bug in UI order amount calcs #185
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ElRodrigote
changed the title
Deploying stackly-ui with
|
| Latest commit: |
1cee850
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4afe683b.stackly-ui.pages.dev |
| Branch Preview URL: | https://fix-stk-233-bug-in-ui-order.stackly-ui.pages.dev |
ElRodrigote
force-pushed
the
fix/stk-233-bug-in-ui-order-amount-calcs
branch
from
ece0f16 to
8ac399b
Compare
berteotti
reviewed
Jul 15, 2024
ElRodrigote
force-pushed
the
fix/stk-233-bug-in-ui-order-amount-calcs
branch
from
c5aae66 to
04c1e69
Compare
berteotti
reviewed
Jul 15, 2024
ElRodrigote
force-pushed
the
fix/stk-233-bug-in-ui-order-amount-calcs
branch
from
5383456 to
1cee850
Compare
|
Closing this PR for now, as the production code as-is displays the same information we get from the SC. In the future we will re-visit the logic we use to handle the stack slots. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: STK-233
Context
After @berteotti investigation on the SC side, he found out that we were not executing a trade on the end date, so we were displaying different computation values in the UI and the SC.
Description
INITIAL_ORDERvalue (=1) from theestimatedNumberOfOrderscalculation to mimic the current logic in the Smart Contract side.