Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STK-253][FIX] - My Stacks displaying NaN #191

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

ElRodrigote
Copy link
Collaborator

Fixes: STK-253

Description

  • Uses the "Start Date" to compute the "Next Order" date for no-slots stacks.
  • Returns 0 if there's no executed buy amount for an order (this may happen if the order expires, for example)

Copy link

vercel bot commented Jul 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stackly-landing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 29, 2024 11:10am

@ElRodrigote ElRodrigote merged commit 6f5dfa5 into develop Jul 29, 2024
4 checks passed
@ElRodrigote ElRodrigote deleted the fix/stk-253-my-stacks-displaying-nan branch July 29, 2024 12:41
Diogomartf added a commit that referenced this pull request Jul 30, 2024
* Add new tokens (#188)

- add new cow token logo
- add shutter and olas to gnosis tokenlist

* fix(STK-255): My Stacks breaks for some one time orders (#189)

* fix: add safeguards to check if the active order has orderSlots
* fix: make 1 slot orders cancellable under correct scenarios

* fix: update confirmation stack logic to handle a minimum date of now + 10 mins (#190)

* fix(STK-253): My Stacks displaying NaN (#191)

* fix: use the start date to compute the 'Next Order' for orders with no slots
* fix: if there's no executed buy amount, return 0 to compute the avg buy price

* fix: hide stacks details if the end date is equal or less than the start date (#192)

---------

Co-authored-by: Rorry <lil.rorry@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants