Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STK-215][FIX] - Completed stack with funds without showing "withdraw" button #195

Conversation

ElRodrigote
Copy link
Collaborator

Fixes: STK-215

Description

  • Updates our checks for stack remaining funds, we had an edge-case bug where if the stack only spent our protocol fee and the stack completed without spending any more funds, we didn't allow the user to withdraw the remaining unspent funds.

Visual Evidence

https://www.loom.com/share/0dbc2f9189104fa9a64e65bb2858927b?sid=fb70b53a-b4d4-4c43-868d-c0d31eb50047

Copy link

vercel bot commented Aug 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stackly-landing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 8, 2024 8:53am

Copy link
Collaborator

@berteotti berteotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice jog Rorry, it's working!

image

@ElRodrigote ElRodrigote force-pushed the fix/stk-215-fix-completed-stack-with-funds-without-showing-withdraw branch from eb744e9 to b626d18 Compare August 8, 2024 08:52
Copy link

cloudflare-workers-and-pages bot commented Aug 8, 2024

Deploying stackly-ui with  Cloudflare Pages  Cloudflare Pages

Latest commit: b626d18
Status: ✅  Deploy successful!
Preview URL: https://4c615720.stackly-ui.pages.dev
Branch Preview URL: https://fix-stk-215-fix-completed-st.stackly-ui.pages.dev

View logs

@ElRodrigote ElRodrigote merged commit eb3965a into develop Aug 8, 2024
4 checks passed
@ElRodrigote ElRodrigote deleted the fix/stk-215-fix-completed-stack-with-funds-without-showing-withdraw branch August 8, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants