Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[STK-256][FIX] - My Stacks not updating correctly #199

Merged
merged 7 commits into from
Aug 22, 2024

Conversation

ElRodrigote
Copy link
Collaborator

@ElRodrigote ElRodrigote commented Aug 14, 2024

Fixes: STK-256

Context

This seems to be the same issue described in our previous issue for a bug in our network switch handling. For more context, please see: #194

Description

  • Persists the chain ID in the search params
  • Resets the stackbox values only if we're changing chains in the landing page

Copy link

vercel bot commented Aug 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stackly-landing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 22, 2024 10:40am

@Diogomartf
Copy link
Collaborator

overall working good, but I found a bug, semi related:

(showing gnosis and arbitrum on the network)
image

If you are on "my stacks" change network and click on "my stacks" it changes the network button to default network (arbitrum). It does not change the network, just the button

8d3836bf0eb3d14f39371f9470328e7e.mp4

Copy link

cloudflare-workers-and-pages bot commented Aug 21, 2024

Deploying stackly-ui with  Cloudflare Pages  Cloudflare Pages

Latest commit: f2dd29f
Status: ✅  Deploy successful!
Preview URL: https://6121b49c.stackly-ui.pages.dev
Branch Preview URL: https://fix-stk-256-my-stacks-not-up.stackly-ui.pages.dev

View logs

@@ -0,0 +1,4 @@
export const PATHNAMES = {
LANDING: "/",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's call it HOME instead

@ElRodrigote ElRodrigote requested a review from berteotti August 22, 2024 10:17
@ElRodrigote ElRodrigote merged commit b48fa30 into develop Aug 22, 2024
4 checks passed
@ElRodrigote ElRodrigote deleted the fix/stk-256-my-stacks-not-updating-correctly branch August 22, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants