Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't break transform when there is no space between unnamed default exported function and generic parameter bracket #305

Merged
merged 1 commit into from
May 4, 2024
Merged

fix: don't break transform when there is no space between unnamed default exported function and generic parameter bracket #305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/transform/preprocess.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,8 @@ export function preProcess({ sourceFile }: PreProcessInput): PreProcessOutput {
nextToken.kind >= ts.SyntaxKind.FirstPunctuation && nextToken.kind <= ts.SyntaxKind.LastPunctuation;

if (isPunctuation) {
code.appendLeft(nextToken.getStart(), defaultExport);
const addSpace = code.slice(token.getEnd(), nextToken.getStart()) != " ";
code.appendLeft(nextToken.getStart(), `${addSpace ? " " : ""}${defaultExport}`);
} else {
code.appendRight(token.getEnd(), ` ${defaultExport}`);
}
Expand Down
10 changes: 10 additions & 0 deletions tests/testcases/unnamed-default-export-without-space/expected.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
/**
* @description @TODO
*/
declare function export_default<T extends object>(
object: T,
initializationObject: {
[x in keyof T]: () => Promise<T[x]>;
},
): Promise<void>;
export { export_default as default };
9 changes: 9 additions & 0 deletions tests/testcases/unnamed-default-export-without-space/index.d.ts
View file
Open in desktop
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are same as https://github.com/Swatinem/rollup-plugin-dts/tree/master/tests/testcases/issue-100-unnamed-default-export but without space between function and <T

Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
/**
* @description @TODO
*/
export default function<T extends object>(
object: T,
initializationObject: {
[x in keyof T]: () => Promise<T[x]>;
},
): Promise<void>;