Merge pull request #5 from Sweetchuck/1.x-cmd-validate-do-not-fail-on…

…-missing Do not fail on "validate" when a *.json suite file is missing
Sweetchuck · May 3, 2021 · e95e980 · e95e980
2 parents f70d7a2 + 1d45377
commit e95e980
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/src/Composer/Plugin.php b/src/Composer/Plugin.php
@@ -125,15 +125,14 @@ protected function onCommandEventValidate(): bool
 
             switch ($whatToDo) {
                 case 'create':
-                    $this->io->error("<error>{$pluginName} - {$newFileName} is not exists</error>");
+                    $this->io->warning("<warning>{$pluginName} - {$newFileName} is not exists</warning>");
                     break;
 
                 case 'update':
+                    $isUpToDate = false;
                     $this->io->error("<error>{$pluginName} - {$newFileName} is not up to date</error>");
                     break;
             }
-
-            $isUpToDate = false;
         }
 
         return $isUpToDate;

diff --git a/tests/acceptance/Composer/Command/ValidateCest.php b/tests/acceptance/Composer/Command/ValidateCest.php
@@ -112,12 +112,15 @@ public function runComposerValidate(AcceptanceTester $I)
         $I->writeToFile("{$this->projectRoot}/composer.one.json", "$threeString\n");
         $I->writeToFile("{$this->projectRoot}/composer.two.json", "$threeString\n");
         $I->runShellCommand("cd $prSafe && composer validate 2>&1");
+        $I->canSeeResultCodeIs(0);
 
         $I->deleteFile("{$this->projectRoot}/composer.one.json");
         $I->deleteFile("{$this->projectRoot}/composer.two.json");
         $I->deleteFile("{$this->projectRoot}/composer.three.json");
         $I->runShellCommand("cd $prSafe && composer suite:generate");
         $I->runShellCommand("cd $prSafe && composer validate");
+        // It is valid when a suite *.json file is missing.
+        $I->canSeeResultCodeIs(0);
     }
 
     protected function selfProjectRoot(): string