-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(improvement) Migrate from clickhouse
to @clickhouse/client
#246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Swetrix/roadmap#217
Migrated everything from
clickhouse
to@clickhouse/client
- now everything is much easier to use and maintain, there's also no need to write raw (parametrised) SQL insert queries, because the new library offers lots of methods for that.Dropped
Redis
for analytics data queuing. Now we rely on asynchronous queries for that. Clickhouse server will create batches on it's own and inject them into the database whenever it's ready. Now the data will be saved to the DB and displayed in dashboard almost instantly.Errors like
Error: 500: Code: 241. DB::Exception: Memory limit (total) exceeded: would use x.xx GiB (attempt to allocate chunk of xxxxxxx bytes), maximum: x.xx GiB. OvercommitTracker decision: Query was selected to stop by OvercommitTracker. (MEMORY_LIMIT_EXCEEDED) (version x.x.x.xx (official build))
will now be prevented because chunks are managed server-side.Self-hosted support
Database migrations
Documentation