Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better string filters documentation #102

Merged
merged 2 commits into from
Sep 5, 2018
Merged

Conversation

djbe
Copy link
Member

@djbe djbe commented Sep 5, 2018

This improves the documentation for the string filters a bit, to have a better overview of the input and output combinations.

Copy link
Contributor

@AliSoftware AliSoftware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the missing detail in one column header, LGTM!
Good to merge once that header is fixed.

| `test\n test` | `testtest` |
| `test, \ntest, \ntest` | `test, test, test` |
| ` test test ` | `test test` |
| Input | Output (`all`) | Output |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Output (leading)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops 😅

@djbe djbe force-pushed the feature/string-filters-readability branch from e75a281 to faa5bb4 Compare September 5, 2018 19:32
@djbe djbe merged commit 1bee94d into master Sep 5, 2018
@djbe djbe deleted the feature/string-filters-readability branch September 5, 2018 19:32
@djbe djbe added this to the 2.7.0 milestone Oct 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants