Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tags & Filters documentation #12

Merged
merged 8 commits into from
Apr 30, 2017
Merged

Tags & Filters documentation #12

merged 8 commits into from
Apr 30, 2017

Conversation

AliSoftware
Copy link
Contributor

Work in Progress

AliSoftware added a commit that referenced this pull request Jan 22, 2017
djbe pushed a commit that referenced this pull request Jan 28, 2017
djbe pushed a commit that referenced this pull request Jan 28, 2017
djbe pushed a commit that referenced this pull request Jan 30, 2017
AliSoftware added a commit that referenced this pull request Feb 19, 2017
djbe pushed a commit that referenced this pull request Mar 4, 2017
djbe pushed a commit that referenced this pull request Mar 10, 2017
@djbe djbe mentioned this pull request Apr 2, 2017
18 tasks
djbe pushed a commit that referenced this pull request Apr 24, 2017
@djbe djbe removed the status: WIP label Apr 26, 2017
@djbe djbe mentioned this pull request Apr 28, 2017
2 tasks
## Filter: "hexToInt"

Accepts a string with a number in hexadecimal format, and converts it into an integer number.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we add examples here same as for other filters?

| Tag Name | `call` |
| End Tag | N/A |
| Rendering | Immediately; output is the rendering of the called macro block |
| Example | `{% call myBlock "Dave" %}` |
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It reads strange I think to have the example here before the table explaining the parameters? Maybe move those examples after the second table in a simple paragraph?

@AliSoftware AliSoftware merged commit 02169c3 into master Apr 30, 2017
@AliSoftware AliSoftware deleted the feature/documentation branch April 30, 2017 12:02
@djbe djbe mentioned this pull request May 8, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants