Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor stencil swift extensions registration for easier use with an existing Extension. #16

Merged
merged 1 commit into from
Jan 28, 2017

Conversation

djbe
Copy link
Member

@djbe djbe commented Jan 27, 2017

No description provided.

Copy link
Contributor

@AliSoftware AliSoftware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me

Can't merge myself though, as I'll probably need a rebase not that the CHANGELOG has other entries by recently merged PR… and I'm in the train with poor connection and fear I'll loose it in the middle of the rebase+merge process 😉

I'll let you rebase + merge

@djbe
Copy link
Member Author

djbe commented Jan 27, 2017

will do

@djbe djbe force-pushed the feature/refactor-extension-creation branch from f51f441 to 77f033e Compare January 27, 2017 22:57
@djbe
Copy link
Member Author

djbe commented Jan 28, 2017

Do note that I can't merge, only you can.

@AliSoftware AliSoftware merged commit 2905c0e into master Jan 28, 2017
@djbe djbe deleted the feature/refactor-extension-creation branch January 28, 2017 14:41
@djbe djbe modified the milestone: 1.0.0 Jan 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants