Remove deprecated, non nested error types #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
AliSoftware
force-pushed
the
feature/breaking/remove-non-nested-errors
branch
from
0391c4f
to
09d125b
Compare
AliSoftware
force-pushed
the
feature/breaking/remove-non-nested-errors
branch
from
09d125b
to
8ca659b
Compare
|
#36 has now been merged and this branch rebased on top of master after the release of 1.0.2 |
djbe
force-pushed
the
feature/breaking/remove-non-nested-errors
branch
from
8ca659b
to
e8bbfa7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sits on top of #36 and is breaking.
It can be considered one small part of #5
It should only be merged once #36 has been merged then released as a new version on CP. Then we could rebase it on top of the new master after release and merge it once we're ready for the next major version to removed the depreciations.
Note that we'll probably have a conflict on the CHANGELOG when rebasing and during that conflict we should make sure to move the entries to the (future) proper section associated with the right version and not to keep them at their current location.
TODO: