Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basename / Dirname filters #60

Merged
merged 4 commits into from
Aug 17, 2017
Merged

Basename / Dirname filters #60

merged 4 commits into from
Aug 17, 2017

Conversation

djbe
Copy link
Member

@djbe djbe commented Aug 16, 2017

Nothing more than .lastPathComponent (same thing PathKit does).

Also added some readme entries for the new filters.

@djbe djbe mentioned this pull request Aug 16, 2017
Merged
1 task
AliSoftware
AliSoftware reviewed Aug 17, 2017
View reviewed changes
Copy link
Contributor

@AliSoftware AliSoftware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It feels strange to add a basename filter but not a dirname filter too while we're at it 😉 care to add that one too?

@djbe djbe changed the title Basename filter Basename / Dirname filters Aug 17, 2017
@djbe djbe merged commit 3ba083d into master Aug 17, 2017
@djbe djbe deleted the feature/basename-filter branch August 17, 2017 10:14
@djbe djbe added this to the 2.1.0 milestone Aug 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AliSoftware AliSoftware AliSoftware approved these changes

Assignees
No one assigned
Labels
type: enhancement
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@djbe @AliSoftware