Enable extra SwiftLint rules #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AliSoftware
requested changes
Mar 28, 2018
.swiftlint.yml
Outdated
| @@ -0,0 +1,43 @@ | |||
| disabled_rules: | |||
| - type_name | |||
There was a problem hiding this comment.
Why disable this rule?
Type name should only contain alphanumeric characters, start with an uppercase character and span between 3 and 40 characters in length.
There was a problem hiding this comment.
That's from the swiftgen repo, just using the same config. I assume it was disabled at some point for some reason? 😅
There was a problem hiding this comment.
Ah! Let's re-enable it and see what violations it reports then 😛
| func testParseBool_TrueWithString() throws { | ||
| // swiftlint:disable force_unwrapping | ||
| XCTAssertTrue(try Filters.parseBool(from: ["true"])!) |
There was a problem hiding this comment.
Same as in SwiftGen/SwiftGen#402: these changes will disappear once #78 is merged. Also applies to the comments below
circle.yml
Outdated
| @@ -4,7 +4,6 @@ machine: | |||
|
|
|||
| dependencies: | |||
| post: | |||
| - bundle exec rake lint:install | |||
rakelib/lint.rake
Outdated
| task :code do |task| | ||
| Utils.print_header 'Linting the code' | ||
| config = Pathname.getwd + '.swiftlint.yml' | ||
| Utils.run(%(#{SWIFTLINT} lint --strict --path Sources --config "#{config}"), task) |
djbe
force-pushed
the
feature/enable-extra-swiftlint-rules
branch
2 times, most recently
from
82fef7a
to
9a8ffb6
Compare
djbe
force-pushed
the
feature/enable-extra-swiftlint-rules
branch
2 times, most recently
from
39eb35c
to
6f701bf
Compare
djbe
force-pushed
the
feature/enable-extra-swiftlint-rules
branch
from
6f701bf
to
e8b8f3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables a bunch of optional SwiftLint rules that ensures the codebase is a bit more consistent.
Same as SwiftGen/SwiftGen#402
Note: built on top of #78, wait until that is merged.