This repository has been archived by the owner on Sep 6, 2018. It is now read-only.
Refactor asset catalog code to use our own parsing instead of actool.
#43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AliSoftware
suggested changes
May 27, 2017
| @@ -7,166 +7,134 @@ | |||
| import Foundation | |||
| import PathKit | |||
|
|
|||
| public enum AssetCatalogParserError: Error, CustomStringConvertible { | |||
There was a problem hiding this comment.
Prefer a nested type inside AsstsCatalogParser
AliSoftware
force-pushed
the
feature/remove-actool
branch
from
ebbae07
to
0b70928
Compare
AliSoftware
approved these changes
May 27, 2017
|
@djbe please ensure that I didn't mess it up during my rebase (it had some conflicts) then you can merge 👍 |
|
After thinking about it, yeah maybe we should remove
|
djbe
force-pushed
the
feature/remove-actool
branch
from
46a178d
to
6f3f75d
Compare
|
Awesome!👏 |
|
Will this be released in SwiftGen soon? I know a forthcoming 5.0 release is in the works, but if that's a while off, maybe this could be released as a hotfix as it fixes an important bug |
|
As soon as I'm back from my vacation on Monday I'll do everything to fast-track the 5.0 release (which is nearly ready and just need to be pushed but I've close to no data in Rio anyway rn so will have to wait for next week for my data and time once back in Europe) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes SwiftGen/SwiftGen#228.
Fixes SwiftGen/SwiftGen#287.
I chose to keep the
Utils/Command.swiftcode, we might want it later. Or should I remove it?