Fonts refactor to use constants

[djbe]

Refactored the generated code to use static let constants instead of cases, as there is no real use case to want to enumerate over a font name.

There were also some issues with the font registration mechanism, which was broken if:

• the font file had a different name than the font name
• a different extension than "ttf" or "otf"

The fonts were also always re-registered if the font name was different from the font family name. We now directly use the path we receive from the parser, and match using the font family name from the parser.

[djbe]

Note that the branch name has "breaking" in it, but the refactored code turns out to be compatible, so yay! 🎉

[Liquidsoul]

I may see one use case where you would want to iterate over the fonts:

• register the fonts ahead of time (e.g. at App startup)

I've done this by adding a static let all: [TheFont] in the enums and then do a all.forEach().register().

[Liquidsoul]

The String, FontConvertible conformance has been removed in your stencils.

[Liquidsoul]

I've made a gist with a enum version with your fixes and the all option on each family name.

[djbe]

Hmm, my original point still stands, there's no reason to enumerate over the fonts, because you can't convert a string to the correct font (using rawValue) unless you already know which font family you're targeting.

That doesn't mean we can't add a all static constant for those that might want it.

[Liquidsoul]

Ok that's fine by me. We just need to remove the : String, FontConvertible part in the markdown files then 😄

[AliSoftware]

@Liquidsoul does my last commit fix your questions? If so could you approve the PR so we can merge? Thx 😉

[Liquidsoul]

@AliSoftware LGTM 👍