This repository has been archived by the owner on Sep 6, 2018. It is now read-only.
Fix link to generated XCAssets example #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djbe
suggested changes
Sep 27, 2017
alvarhansen
force-pushed
the
generated-code-link-fix
branch
from
60cdbe2
to
18f3117
Compare
|
Done. I put it under "Bug Fixes". Although I am not sure if it goes there or under "Internal Changes". |
|
Thanks for the contribution @allu22 ! I'd say the Bug Fixes section is OK. After all documentation is very important and I consider it a bug if it's wrong and gives you the wrong information, so that section is fine by me 👍 |
AliSoftware
approved these changes
Sep 27, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of bf58bf3,
Documentation/xcassets/swift2.md,Documentation/xcassets/swift3.mdandDocumentation/xcassets/swift4.mdhave broken links to "Full generated code".This pull request will update XCAssets fully generated code example links:
swift2-context-defaults.swift->swift2-context-all.swiftswift3-context-defaults.swift->swift3-context-all.swiftswift4-context-defaults.swift->swift4-context-all.swift