Hotfix/expose image name

[abbeyjackson]

Change private access to private(set) in order to expose image name on swift2.stencil, swift3.stencil and swift4.stencil for the xcassets folder.

[AliSoftware]

Thanks for the PR!

Don't forget to:

• Update the Unit Tests. You can do that by opening the xcworkspace, selecting the "Generate Output" scheme, and hit Cmd-U. (†)
• Add an entry in the CHANGELOG to credit yourself (be sure to respect the same format as the other entries, especially the two spaces after the period at the end of the description line

---

(†) This will run the tests, which use your templates to generate the outputs… then instead of comparing that generated output to the expected files like normal tests do with the "Tests" scheme, the "Generate Output" scheme will end up overriding the expected output files with the generated output, to update them. This way, you don't have to update all fixtures for the unit tests manually! Run the Generate Output and let it do the work for you 😉

[AliSoftware]

• Update unit tests (by just hitting Cmd-U on the "Generate Output" scheme in the Xcode workspace)
• Add a CHANGELOG entry to log the change and credit yourself

[AliSoftware]

Just a little adjustment for the CHANGELOG, otherwise LGTM!

[AliSoftware]

Please move your entry under ## Master — that's what it's there for — rather than assuming that the next version will be a 2.2.1 (we might not release a new version immediately so maybe there will be other PRs by other people that will make us need to bump the minor version when we decide to release) 😉

[AliSoftware]

@abbeyjackson Sorry for the inconvenience, but it happens that we just realised an issue with our CI vs Xcode 9, which I just fixed recently on master… but wasn't fixed at the time you opened your PR.

So if you could rebase your branch on top of the master branch, that will allow you to include that CircleCI fix and avoid the CI to fail on your PR because of this issues which would have nothing to do with your code

[abbeyjackson]

@AliSoftware okay I'll have to do this back at home tonight since I don't think you can rebase via the github website can you...?

[AliSoftware]

No sadly you can't rebase via the web interface 😢

[abbeyjackson]

@AliSoftware just got my magic goblin to do it! hah!

[diederich]

Nice, just found this when I found out that the name of the color is fileprivate as well. Should we change that too?

[AliSoftware]

@diederich I didn't realize people had a use for accessing the string name of those assets, hence them being fileprivate so far.

But indeed now that you talk about it, for consistency we should definitely apply the same change to color templates too! Would welcome a PR 😉

[diederich]

Yeah, I stumbled over the allColors array, and just hacked a TableVC together to show the Colors that's used in an app. And there the name would indeed be nice. I'll look into it..