Skip to content

Commit

Permalink
Merge pull request mixxxdj#12709 from mixxxdj/taglib_20_fail
Browse files Browse the repository at this point in the history
Fail early in case Taglib 2.0 is found
  • Loading branch information
Swiftb0y authored Feb 4, 2024
2 parents e0322b2 + 4d02b1b commit 4cfb8c4
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2940,6 +2940,13 @@ target_link_libraries(mixxx-lib PRIVATE SoundTouch::SoundTouch)
# TagLib
find_package(TagLib 1.11 REQUIRED)
target_link_libraries(mixxx-lib PRIVATE TagLib::TagLib)
if (NOT TagLib_VERSION VERSION_LESS 2.0.0)
message(FATAL_ERROR "Installed Taglib ${TagLib_VERSION} is not supported. Use Version >= 1.11 and < 2.0 and its development headers.")
# Dear package maintainer: Do not patch away this fatal error
# using taglib 2.0.0 will put user data at risk!!
# Mixxx is a complex application that needs to be adapted and tested thoroughly
# https://github.com/mixxxdj/mixxx/issues/12708
endif()

# Threads
set(THREADS_PREFER_PTHREAD_FLAG ON)
Expand Down

0 comments on commit 4cfb8c4

Please sign in to comment.