Feature set background color for state in UIButton #1041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomanPodymov
requested changes
Aug 29, 2022
Codecov Report
@@ Coverage Diff @@
## master #1041 +/- ##
==========================================
- Coverage 95.50% 92.85% -2.65%
==========================================
Files 105 105
Lines 3737 3753 +16
==========================================
- Hits 3569 3485 -84
- Misses 168 268 +100
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
LucianoPAlmeida
previously approved these changes
Aug 30, 2022
Generated by 🚫 Danger |
LucianoPAlmeida
approved these changes
Aug 31, 2022
RomanPodymov
approved these changes
Aug 31, 2022
|
Thank you for contributing to SwifterSwift! I've invited you to join the SwifterSwift GitHub organization - no pressure to accept! If you'd like more information on what that means, check out our contributing guidelines. Feel free to reach out if you have any questions! 😃 |
|
Thanks @TwizzyIndy @RomanPodymov! |
wesmatlock
added a commit
to wesmatlock/SwifterSwift
that referenced
this pull request
Dec 22, 2023
* Update issue templates (SwifterSwift#931) * Update issue templates * Removing old template * [NFC] Fixing shorthand swiftlint warnigs (SwifterSwift#932) * [CI] Updating brew (SwifterSwift#938) * Add New Extension `MeasurementExtensions` (SwifterSwift#936) * Add New Extension `MeasurementExtensions` Add static initializers to create measurement instances presenting angle in various unit types. * PR Improvements * Update CHANGELOG.md Co-authored-by: Henry <thisisthefoxe@gmail.com> * Update Sources/SwifterSwift/Foundation/MeasurementExtensions.swift Co-authored-by: Guy Kogus <guy.kogus@gmail.com> * Update CHANGELOG.md Co-authored-by: Guy Kogus <guy.kogus@gmail.com> * Update Copyright - Happy New Year! * Update Test Cases Extract a top-level constant for angle value. Update function call for `.degrees(_:)`. * Update Sources/SwifterSwift/Foundation/MeasurementExtensions.swift Co-authored-by: Luciano Almeida <passos.luciano@outlook.com> * PR Improvement Use explicit `return`. Co-authored-by: Henry <thisisthefoxe@gmail.com> Co-authored-by: Guy Kogus <guy.kogus@gmail.com> Co-authored-by: Luciano Almeida <passos.luciano@outlook.com> * Cleanup `@available` attribute declaration that doesn't need anymore. (SwifterSwift#941) * Fix several typos, omissions I've noticed in the documentation. (SwifterSwift#937) * Fix several documentation typos. * Some more documentation improvements :P Co-authored-by: Guy Kogus <guy.kogus@gmail.com> * fix replace "0x" bug (SwifterSwift#947) * Adding changelog for SwifterSwift#947 * [5.3] All adjustments for the next release (SwifterSwift#948) * Bump kramdown from 2.3.0 to 2.3.1 (SwifterSwift#950) Bumps [kramdown](https://github.com/gettalong/kramdown) from 2.3.0 to 2.3.1. - [Release notes](https://github.com/gettalong/kramdown/releases) - [Changelog](https://github.com/gettalong/kramdown/blob/master/doc/news.page) - [Commits](https://github.com/gettalong/kramdown/commits) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump rexml from 3.2.4 to 3.2.5 (SwifterSwift#953) Bumps [rexml](https://github.com/ruby/rexml) from 3.2.4 to 3.2.5. - [Release notes](https://github.com/ruby/rexml/releases) - [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md) - [Commits](ruby/rexml@v3.2.4...v3.2.5) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix missing public identifiers (SwifterSwift#960) * Add unsafeString initializer for URL (SwifterSwift#965) * Add unsafeString initializer for URL * Update CHANGELOG.md Co-authored-by: Luciano Almeida <passos.luciano@outlook.com> Co-authored-by: Luciano Almeida <passos.luciano@outlook.com> * Added UITextField Extensions for adding tool bar. (SwifterSwift#954) * RandhirKumar: Added UITextField Extensions for adding toolbar to textfield. * RandhirKumar: Added Unit tests for UITextField Extensions * RandhirKumar: updated change log for newly added extensions. * SwifterSwift: Address PR comments and refactor tests file. * Updated Changelog.md * Update CHANGELOG.md Co-authored-by: Guy Kogus <guy.kogus@gmail.com> * Updated changelog.md * Removed extra parenthesis in changelog.md * SwifterSwift: Code refactor as per review comments. * Update CHANGELOG.md Co-authored-by: Guy Kogus <guy.kogus@gmail.com> * SwifterSwift: Address PR comments. * SwifterSwift: Added a os check. * SwifterSwift: updated tests with os check. Co-authored-by: Randhir kumar <randhir_kumar@intuit.com> Co-authored-by: Guy Kogus <guy.kogus@gmail.com> * Fix Slack badge (SwifterSwift#968) * Add `beginRefreshing(animated:sendAction:)` that works inside any… (SwifterSwift#949) * Array append for optional element and sequences (SwifterSwift#966) * [BugFix]Making String.base64Decoded a safe base64 decode by ignore non-base64 characters (SwifterSwift#961) * [BugFix]Making String.base64Decoded a safe base64 decode by ignore non-base64 characters * add changelog * Update StringExtensionsTests.swift Co-authored-by: Luciano Almeida <passos.luciano@outlook.com> * Modify error comments (SwifterSwift#974) * Rename conflicting UIView extensions (SwifterSwift#972) Co-authored-by: Luciano Almeida <passos.luciano@outlook.com> Co-authored-by: Guy Kogus <guy.kogus@gmail.com> * Add `init?(argbHexString:)` to support the common ARGB format used in Android (SwifterSwift#971) * Bump addressable from 2.7.0 to 2.8.0 (SwifterSwift#975) * Added SKSpriteNode extension (SwifterSwift#980) * Update CI.yml (SwifterSwift#988) * Use BinaryInteger as bytes (SwifterSwift#987) * add `BinaryInteger` extension & Tests Co-authored-by: Guy Kogus <guy.kogus@gmail.com> Co-authored-by: Luciano Almeida <passos.luciano@outlook.com> * Add `MKMultiPoint` extensions (SwifterSwift#990) * Add `MKMultiPoint` extensions * Remove duplicate tests for MKPolyLine coordinates * Update CHANGELOG.md * Adding subviewsOfType extension to UIViewExtensions (SwifterSwift#993) * Adding subviewsOfType extension * Update Changelog * Improve test * Add check for empty subviews * Update CHANGELOG.md Co-authored-by: Luciano Almeida <passos.luciano@outlook.com> * Fix tests * Update comment * Fix test Co-authored-by: Luciano Almeida <passos.luciano@outlook.com> * Stackview/swap (SwifterSwift#989) * implment swap function * add test for swap function * support animate on swap action * Update CHANGELOG.md * Update CHANGELOG.md Co-authored-by: Luciano Almeida <passos.luciano@outlook.com> * Update Tests/UIKitTests/UIStackViewExtensionsTests.swift Co-authored-by: Luciano Almeida <passos.luciano@outlook.com> * move private swap function inside public swap function as local function. * add new test case of call swap with a view that is not on the stack nothing should happen Co-authored-by: Luciano Almeida <passos.luciano@outlook.com> * Add joined(separator:) (SwifterSwift#985) * Add joined(separator:) * Update CHANGELOG.md * Update NSAttributedStringExtensions.swift * Update Sources/SwifterSwift/Foundation/NSAttributedStringExtensions.swift Co-authored-by: Luciano Almeida <passos.luciano@outlook.com> * fix build errors * more tests * Update Sources/SwifterSwift/Foundation/NSAttributedStringExtensions.swift Co-authored-by: Luciano Almeida <passos.luciano@outlook.com> * Fix tests * testJoinedWithNonEmptySeparator * testJoinedWithEmptyAttributedSeparator * tests * #if canImport(AppKit) || canImport(UIKit) outside methods Co-authored-by: Luciano Almeida <passos.luciano@outlook.com> * UIImage with color (SwifterSwift#977) Co-authored-by: Luciano Almeida <passos.luciano@outlook.com> Co-authored-by: Guy Kogus <guy.kogus@gmail.com> * func setAttributedTitleForAllStates(_ title: NSAttributedString) (SwifterSwift#1001) * Add README Chinese document. (SwifterSwift#1005) * Add README Chinese document. * Update README Chinese document. * Update README Chinese document. * Bump cocoapods-downloader from 1.4.0 to 1.6.3 (SwifterSwift#1007) Bumps [cocoapods-downloader](https://github.com/CocoaPods/cocoapods-downloader) from 1.4.0 to 1.6.3. - [Release notes](https://github.com/CocoaPods/cocoapods-downloader/releases) - [Changelog](https://github.com/CocoaPods/cocoapods-downloader/blob/master/CHANGELOG.md) - [Commits](CocoaPods/cocoapods-downloader@1.4.0...1.6.3) --- updated-dependencies: - dependency-name: cocoapods-downloader dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump git from 1.8.1 to 1.11.0 (SwifterSwift#1009) * Bump jmespath from 1.4.0 to 1.6.1 (SwifterSwift#1015) * deletingAllPathComponents can now handle empty paths (SwifterSwift#1018) * Fixes SwifterSwift#1012 - deletingAllPathComponents can now handle empty paths * Fixes UIView.rotate(toAngle) (SwifterSwift#1019) * Project fixes (SwifterSwift#1017) * Fix compiling and tests * Cleans up ResourceTests folder to make it more compatible with SPM * Update CONTRIBUTING.md (SwifterSwift#1024) - Fix typos - Add examples for allowed/disallowed code - Remove changelog entry to lower entry friction for new joiners * hexString computed property for CryptoKit.Digest (SwifterSwift#1026) * hexString computed property for CryptoKit.Digest * Update Sources/SwifterSwift/CryptoKit/DigestExtensions.swift Co-authored-by: Luciano Almeida <passos.luciano@outlook.com> * Improvements to DigestExtensions per code review Co-authored-by: Luciano Almeida <passos.luciano@outlook.com> * Bump tzinfo from 1.2.9 to 1.2.10 (SwifterSwift#1028) Bumps [tzinfo](https://github.com/tzinfo/tzinfo) from 1.2.9 to 1.2.10. - [Release notes](https://github.com/tzinfo/tzinfo/releases) - [Changelog](https://github.com/tzinfo/tzinfo/blob/master/CHANGES.md) - [Commits](tzinfo/tzinfo@v1.2.9...v1.2.10) --- updated-dependencies: - dependency-name: tzinfo dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Removing Xctool from project (SwifterSwift#1035) * Feature set background color for state in UIButton (SwifterSwift#1041) * Hotfix accuracy (SwifterSwift#1044) * accuracy * Another color * Updated DigestExtensions to compile on Xcode 14 Beta (SwifterSwift#1045) * Added missing changelog for PR SwifterSwift#1045 (SwifterSwift#1046) SwifterSwift#1045 * fix nearestTenMinutes behavior (SwifterSwift#1034) * fix nearestTenMinutes behavior * add additional test cases to demonstrate rounding consistency * add changelog * Update CHANGELOG.md Co-authored-by: Guy Kogus <guy.kogus@gmail.com> Co-authored-by: Guy Kogus <guy.kogus@gmail.com> * [CI] Fixing CI issues (SwifterSwift#1056) * [CI] Fixing ruby CI issue * [CI] Export ruby to path * Updating xcode to 13 * Update xcode for pods matrix * WatchOS Failure * Fix tvOs * Commenting summary * Rename Color, EdgeInset and Font typealiases to fix namespace conflicts with SwiftUI Types 🚀 (SwifterSwift#1055) * Fix SwiftUI namespace conflict by renaming Color typealias to SFColor and EdgeInsets to SFEdgeInsets. * Rename Font typealias to SFFont to fix SwiftUI's Font namespace conflict * Add change log entry. Co-authored-by: Luciano Almeida <passos.luciano@outlook.com> * Update README.md 🚀 (SwifterSwift#1030) * Update README.md * Update README.md Co-authored-by: Luciano Almeida <passos.luciano@outlook.com> * Update README.md Co-authored-by: Luciano Almeida <passos.luciano@outlook.com> Co-authored-by: Luciano Almeida <passos.luciano@outlook.com> Co-authored-by: Guy Kogus <guy.kogus@gmail.com> * Update README_CN.md 🚀 (SwifterSwift#1031) * Update README_CN.md * Update links to match SwifterSwift#1030 * Update README_CN.md Co-authored-by: Guy Kogus <guy.kogus@gmail.com> Co-authored-by: Luciano Almeida <passos.luciano@outlook.com> * Fix swiftlint warnings (SwifterSwift#1060) * Add Array.init(numberOfElements:,element:) initializer (SwifterSwift#1051) * Add Array.init(numberOfElements:,element:) initializer * Update CHANGELOG.md Co-authored-by: Luciano Almeida <passos.luciano@outlook.com> * Fix docstring in Sources/SwifterSwift/SwiftStdlib/ArrayExtensions.swift Co-authored-by: Guy Kogus <guy.kogus@gmail.com> * Fix Array.init(count:, element:) - make it rethrowing Co-authored-by: Luciano Almeida <passos.luciano@outlook.com> Co-authored-by: Guy Kogus <guy.kogus@gmail.com> * Add .focused (SwifterSwift#1062) * .focused * Update CHANGELOG.md * Focused state (SwifterSwift#1063) * Focused state * Typo * Update CHANGELOG.md * Bump git from 1.12.0 to 1.13.0 (SwifterSwift#1070) * Bump activesupport from 6.1.7 to 6.1.7.1 (SwifterSwift#1073) Bumps [activesupport](https://github.com/rails/rails) from 6.1.7 to 6.1.7.1. - [Release notes](https://github.com/rails/rails/releases) - [Changelog](https://github.com/rails/rails/blob/v7.0.4.1/activesupport/CHANGELOG.md) - [Commits](rails/rails@v6.1.7...v6.1.7.1) --- updated-dependencies: - dependency-name: activesupport dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add `DefaultStringInterpolation.appendInterpolation(_:placeholder:predicate:)` method for providing placeholder string if interpolated value is `nil` or the optional predicate closure returns `false` (SwifterSwift#1074) * Add New Extension `DefaultStringInterpolationExtensions` * WIP * Update CHANGELOG.md * [Misc] Remove Unneccessary Import * [Refactor] Change Function Signature * [Misc] Update `README.md` * URLSession.dataSync(for request: URLRequest) throws -> (Data, URLResponse) (SwifterSwift#1076) * URLSessionExtensions * Tests * Update CHANGELOG.md * Improved tests * Fix for Linux * More fixes for Linux * Update CHANGELOG.md Co-authored-by: Guy Kogus <guy.kogus@gmail.com> * Update Sources/SwifterSwift/Foundation/URLSessionExtensions.swift Co-authored-by: Guy Kogus <guy.kogus@gmail.com> * Update Tests/FoundationTests/URLSessionExtensionsTests.swift Co-authored-by: Guy Kogus <guy.kogus@gmail.com> * More random * Documentation * Fix build errors * Update Sources/SwifterSwift/Foundation/URLSessionExtensions.swift Co-authored-by: Guy Kogus <guy.kogus@gmail.com> * Update README.md * Cut * For all platforms * Another scheme * http * Update README_CN.md --------- Co-authored-by: Guy Kogus <guy.kogus@gmail.com> * Change Implementation of `DefaultStringInterpolation.appendInterpolation(_:placeholder:where:)` (SwifterSwift#1083) Use `appendInterpolation(_:)` instead of `appendLiteral(_:)` for better handling interpolation behavior. * chore(typos): fix typos (SwifterSwift#1086) * chore(typos): fix typos * revert change to original inout instead of input * revert change to original inout instead of input * revert change to original inout instead of input * revert change to original inout instead of input * revert change to original splitted instead of split * improve naming * Added `pairs` function to Collection (SwifterSwift#1094) * Add `pairs` function to collection * Add unit test case for `pairs` function * Update CHANGELOG.md * Add unit test cases for `pairs` - unit test cases are added for even, odd and empty collection * Change function name to `adjacentPairs` * Simplify tests by removing unwanted loops * Update CollectionExtensionsTests.swift * Bump activesupport from 6.1.7.1 to 6.1.7.3 (SwifterSwift#1097) * Improve documentation for localized method in StringExtensions. (SwifterSwift#1099) * chore: Lint and Fix Description of `Collection.adjacentPairs()` (SwifterSwift#1102) * Remove warning in NotificationCenterExtensions.swift (SwifterSwift#1104) * Upgrade deprecated linux version (SwifterSwift#1108) * Replaced the for-each anchors activation with `NSLayoutConstraint` (SwifterSwift#1107) - If we are creating constraints programmatically, using the activate method can improve performance by activating all the constraints at once, rather than activating them one by one. Co-authored-by: Mayank <> Co-authored-by: Luciano Almeida <passos.luciano@outlook.com> * Fixes building HKActivitySummary for macOS (SwifterSwift#1059) * Fixes building for macOS * Fix comment * Fix deprecation usage * Add CHANGELOG * [WatchOS] Fix watchOS build failure * [github] Update xcode version * [watchOS] Fix simulator device * Try again * Name escape * [Pods] Update pods * Add a bit more info * Unquote --------- Co-authored-by: Chen <qchenqizhi@gmail.com> Co-authored-by: Luciano Almeida <passos.luciano@outlook.com> * Minor changes in Optional Collection extensions. 🚀 (SwifterSwift#1110) - Instead of checking for nil using guard statements we are using self and some basic conditions - This optimises the performance significantly considering that collection size can be bigger and checking using guard can be expensive. --------- Co-authored-by: Mayank <> * Add `addGradient(colors:locations:direction:)` extension (SwifterSwift#1039) --------- Co-authored-by: Guy Kogus <guy.kogus@gmail.com> Co-authored-by: Phill Zarfos <pzarfos@thepennyhoarder.com> * Fixed `String.subscript(safe:)` to correctly check for valid ranges of different types (SwifterSwift#1114) * Deprecate `String.init(randomOfLength:)` in favor of `String.random(ofLength:)` (SwifterSwift#1115) Co-authored-by: Luciano Almeida <passos.luciano@outlook.com> * Reverse the parameters for the ~= String operator to not break the default implementation (SwifterSwift#1113) * Add `URLQueryItem` variants to `URL` query parameter extensions (SwifterSwift#1116) * Change the methods of UINavigationBarExtensions to use UINavigationBarAppearance for support iOS 15 and later versions. (SwifterSwift#1105) * Make Date.weekday documentation clearer (SwifterSwift#1118) * Fix test compilation * Add `formatLocalized` method to format localized strings easily (SwifterSwift#1100) * Bump activesupport from 6.1.7.3 to 7.0.7.2 (SwifterSwift#1128) * Feature Extend a property backgroundViewColor for UIStackView to set its background color (SwifterSwift#1127) * Fix: compilation errors for visionOS platform (SwifterSwift#1129) * Add `method` operator to URLRequest (SwifterSwift#1133) * Add `header(name:, value:)` method to URLRequest (SwifterSwift#1134) * Adds `isInRange(of:radius:unit:)` to `CLLocation` (SwifterSwift#1095) Co-authored-by: Luciano Almeida <passos.luciano@outlook.com> Co-authored-by: Guy Kogus <guy.kogus@gmail.com> * Run swiftformat (SwifterSwift#1137) * Hide bottom bar (SwifterSwift#1117) * Add pushViewController(_ viewController:, hideBottomBar:) UINavigationController Extensions --------- Co-authored-by: Guy Kogus <guy.kogus@gmail.com> * Fixes tests for iOS 17 (SwifterSwift#1136) * Run SwiftFormat and SwiftLint at the start of each build phase (SwifterSwift#1141) * Combine.Future Extensions (SwifterSwift#1139) Co-authored-by: Guy Kogus <guy.kogus@gmail.com> * Upgrade minimum deployment versions to match Xcode 15 recommendations (SwifterSwift#1142) * Release 6.0.0 (SwifterSwift#1145) * Release 6.0.0 * Removes deprecated extensions * Enable Swift 6 upcoming features support (SwifterSwift#1146) * Update README.md for v6.0.0 Release (SwifterSwift#1148) * Fix UIView.GradientDirection access level (SwifterSwift#1152) Fixes SwifterSwift#1151 * Fix running Swiftformat --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Luciano Almeida <passos.luciano@outlook.com> Co-authored-by: Shiva Huang <shiva.huang@cocoazen.com> Co-authored-by: Henry <thisisthefoxe@gmail.com> Co-authored-by: Guy Kogus <guy.kogus@gmail.com> Co-authored-by: Manuel Carlos <manuelcarloslopes@icloud.com> Co-authored-by: Zero.D.Saber <fuxianchao@gmail.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jevon Mao <woodburyjevonmao@gmail.com> Co-authored-by: Randhir Kumar <randhirkumar.rk65@gmail.com> Co-authored-by: Randhir kumar <randhir_kumar@intuit.com> Co-authored-by: Omar Albeik <omaralbeik@gmail.com> Co-authored-by: Yonat Sharon <yonat@ootips.org> Co-authored-by: Jayxiang <610469644@qq.com> Co-authored-by: feixue299 <ariablink299@gmail.com> Co-authored-by: Erik Drobne <erik.drobne@gmail.com> Co-authored-by: Rizwan Mohamed Ibrahim <rizwankce@users.noreply.github.com> Co-authored-by: Asher Coelho <asher.coelho@gmail.com> Co-authored-by: Salah Nahed <salahamassi@users.noreply.github.com> Co-authored-by: Roman Podymov <podymfrombryansk@yandex.ru> Co-authored-by: 独木舟的木 <andywhm@163.com> Co-authored-by: Omar Albeik <8127757+omaralbeik@users.noreply.github.com> Co-authored-by: Marco Eidinger <eidingermarco@gmail.com> Co-authored-by: Aung Khant Myo <aungkhantmyo2112@gmail.com> Co-authored-by: theedov <bogdan@dovgopol.dev> Co-authored-by: theedov <theo@dovgopol.dev> Co-authored-by: Morgan Dock <mmdock@users.noreply.github.com> Co-authored-by: Mussa Charles <mussacharles50@gmail.com> Co-authored-by: Sara Tavares <29093946+stavares843@users.noreply.github.com> Co-authored-by: Victor Telitsyn <8170445+viktart@users.noreply.github.com> Co-authored-by: Boudhayan Biswas <hello@boudhayan.com> Co-authored-by: Mustafa Ali Akçakır <44831689+makcakir@users.noreply.github.com> Co-authored-by: TTOzzi <devTTOzzi@gmail.com> Co-authored-by: Mayank Kumar Gupta <43279178+Mayank-84@users.noreply.github.com> Co-authored-by: Chen <qchenqizhi@gmail.com> Co-authored-by: Phill Zarfos <pzarfos@thepennyhoarder.com> Co-authored-by: biao <544856638@qq.com> Co-authored-by: Ricardo Rauber <ricardorauber@gmail.com> Co-authored-by: never-better <71776532+never-better@users.noreply.github.com> Co-authored-by: KHAIRUL ISLAM <imdkhairul@gmail.com> Co-authored-by: Roman Podymov <podymfrombryansk@yandex.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is referenced on #1037 .
Checklist
@availableif not.