Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Casting to NSDictionary instead of [String : AnyObject] #137

Closed
wants to merge 1 commit into from
Closed

Casting to NSDictionary instead of [String : AnyObject] #137

wants to merge 1 commit into from

Conversation

tkhikage
Copy link

#102
I had have same probrem.
I examined the issue with Time Profiler Instruments, and found that casting to [String : AnyObject] is very slow.
On a trial basis , I changed to cast to NSDictionary, and it improved perfromance.
There was no probrem in unit testing.

By the way , this is my first pull request in my github life.Please forgive me if something wrong.And sorry for my poor English.

@LukeTangPL
Copy link
Member

In JSON. An object is an unordered set of name/value pairs, the name must be String.

@LukeTangPL LukeTangPL closed this Jan 26, 2015
@seboslaw
Copy link

@tkhikage
Copy link
Author

tkhikage commented Mar 3, 2015

@seboslaw Thank you for commenting.
I'm wondering why this is so slow like this ...
Currently, I'm not using SwiftyJSON in cases requiring performance.(This is not the probrem of SwiftyJSON,though.)

@LukeTangPL
Copy link
Member

#200

@ThoseGuysInTown
Copy link

@seboslaw Why does your Xcode have those % indicators on the right side?

@seboslaw
Copy link

seboslaw commented Feb 6, 2017

@ThoseGuysInTown That's actually the "Time Profiler" in Instruments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants