Add support for MDL CSS Framework #686
Conversation
| @@ -157,6 +157,12 @@ describe('gulp-angular bower template', function () { | |||
| result.should.not.match(/foundation/); | |||
| result.should.not.match(/material/); | |||
|
|
|||
| model.props.ui.key = 'mdl'; | |||
| result = bower(model) | |||
There was a problem hiding this comment.
@drGrove can you add semicolon ?
|
Thank you. :) |
|
Maybe we should propose option for https://github.com/jadjoubran/angular-material-design-lite ? |
|
Wasn't so sure about adding a new ui framework but this one is great and your integration is also great. I can't honestly refuse this :) 👍 |
|
@zckrs, |
|
@drGrove Yeah MDL and Angular-Material are two different implementation But I think about MDL and Angular-Material-Design-Lite |
|
@zckrs, |
|
We should not wait integrate AMDL before merge this feature @Swiip ? I am not sure one day AMDL release v1.0.0 Maybe @jadjoubran can help about this point. |
|
Hi, Thanks for bringing this up! Version 1.0 marks the integration of the most common components available in MDL + a fix for the following issue #4 which requires an upstream fix. But AMDL can be used today even though it hasn't reached v1.0.0 that's because if a component is not available as a directive yet, you can just use the plain MDL component (same thing if you hit a limitation). |
|
What are your thoughts? Should I start working on an integration with AMDL as well? |
|
I think that even if AMDL is very young, it's interesting to offer a component library along with the choice of the UI framework so I think we should include it. If you are willing to do the work, it's perfect, but just to be clear, you already did a great job and your PR will be merged even if you don't take this charge on you |
|
@Swiip, |
|
@drGrove IMO the best solution is
But at moment we can support only:
|
No description provided.