Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for bug #660 (index.html file is incorrectly reloaded) #904

Merged
merged 3 commits into from
Nov 18, 2015

Conversation

dtolstyi
Copy link

Separated logic of reload and compilation for Gulp 3.x allowing to make proper reload for index.html and other assets.
Fix for bug #660

@Swiip
Copy link
Owner

Swiip commented Nov 17, 2015

👍

Swiip added a commit that referenced this pull request Nov 18, 2015
Fix for bug #660 (index.html file is incorrectly reloaded)
@Swiip Swiip merged commit 9919934 into Swiip:master Nov 18, 2015
@alfaproject
Copy link
Contributor

Editing a SCSS file now will trigger a full page reload, while before it would only update the stylesheet without a full page reload. To be honest, I prefer the old way.

@Swiip
Copy link
Owner

Swiip commented Nov 18, 2015

Arg, I've to look deeper...

@alfaproject
Copy link
Contributor

For now, I changed the styles reload task to this:

    gulp.task('styles-reload', ['styles'], function() {
        browserSync.reload('*.css');
    });

It's hacky as fuck, but gets the job done until I can think of a cleaner solution.

@Swiip
Copy link
Owner

Swiip commented Nov 18, 2015

Thanks for sharing.

@dtolstyi
Copy link
Author

Yes, I see. The problem is that now we are calling browserSync.reload(); without stream:true parameter. In the evening I will try to change the process a bit. I got some ideas for this...

@dtolstyi dtolstyi deleted the fix/660 branch November 18, 2015 23:27
@dtolstyi
Copy link
Author

Ok, I've did a new PR: #911 which takes into account problem mentioned by @alfaproject . Now, in case of styles changes, reload is being done only to styles themselves instead of full page reload.

@zckrs zckrs mentioned this pull request Nov 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants