feat: serve assets in unit tests #915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When unit-testing a directive, and the template of the directive contains, for example
<img src="/assets/angular.png" />
a 404 warning is displayed in the karma console because the image isn't served by Karma.
This commit configures karma to also serve assets, to avoid that warning (and possible
other complications caused by the absence of assets).
|
I never faced this need and you fix seams legit. 👍 Thanks. |
Swiip
added a commit
that referenced
this pull request
Nov 23, 2015
feat: serve assets in unit tests
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When unit-testing a directive, and the template of the directive contains, for example
a 404 warning is displayed in the karma console because the image isn't served by Karma.
This commit configures karma to also serve assets, to avoid that warning (and possible
other complications caused by the absence of assets).