-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: modify login theme layout and texts (#2884) #26
Conversation
c0abdc4
to
be3e812
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very good 🤩 !
For maintainability, it would be nice if the localization file only contained the strings that are different from the default.
7587d63
to
6825a3b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! (I added a commit to fix newline issues in the css and localization file).
…nto 000-modify-login-theme-layout # Conflicts: # renku_theme/login/messages/messages_en.properties
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
PR to apply new layout design for login theme.
when no providers exist:
Fix SwissDataScienceCenter/renku-ui#2884