Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: modify login theme layout and texts (#2884) #26

Merged
merged 5 commits into from
Nov 15, 2023

Conversation

andre-code
Copy link
Contributor

@andre-code andre-code commented Nov 8, 2023

PR to apply new layout design for login theme.

login theme

when no providers exist:

Screenshot 2023-11-13 at 09 58 04

Fix SwissDataScienceCenter/renku-ui#2884

Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very good 🤩 !

For maintainability, it would be nice if the localization file only contained the strings that are different from the default.

renku_theme/login/messages/messages_en.properties Outdated Show resolved Hide resolved
ciyer
ciyer previously approved these changes Nov 9, 2023
Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! (I added a commit to fix newline issues in the css and localization file).

…nto 000-modify-login-theme-layout

# Conflicts:
#	renku_theme/login/messages/messages_en.properties
Copy link
Contributor

@ciyer ciyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@andre-code andre-code merged commit 2aebe38 into master Nov 15, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

keycloak: modify login layout
2 participants