Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix polylith error in tests #426

Merged
merged 1 commit into from
Sep 25, 2024
Merged

chore: fix polylith error in tests #426

merged 1 commit into from
Sep 25, 2024

Conversation

olevski
Copy link
Member

@olevski olevski commented Sep 25, 2024

No description provided.

@olevski olevski requested a review from a team as a code owner September 25, 2024 09:55
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11030681509

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.02%) to 90.432%
Files with Coverage Reduction New Missed Lines %
components/renku_data_services/base_api/pagination.py 1 84.21%
components/renku_data_services/storage/blueprints.py 1 94.76%
components/renku_data_services/users/db.py 1 94.18%
components/renku_data_services/crc/blueprints.py 3 93.19%
Totals Coverage Status
Change from base Build 10989111045: -0.02%
Covered Lines: 9329
Relevant Lines: 10316
💛 - Coveralls

leafty
leafty approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@leafty leafty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏

@olevski olevski self-assigned this Sep 25, 2024
@olevski olevski merged commit 0136831 into main Sep 25, 2024
15 checks passed
@olevski olevski deleted the chore-fix-polylith-fakeredis branch September 25, 2024 12:48
leafty pushed a commit that referenced this pull request Sep 26, 2024
@olevski @leafty
chore: fix polylith error in tests (#426)
fd01865
leafty pushed a commit that referenced this pull request Sep 27, 2024
@olevski @leafty
chore: fix polylith error in tests (#426)
6d92c14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leafty leafty leafty approved these changes

@sgaist sgaist sgaist approved these changes

Assignees

@olevski olevski

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@olevski @coveralls @sgaist @leafty