Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use typed patch instance for platform config updates #499

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

leafty
Copy link
Member

@leafty leafty commented Nov 1, 2024

See #485.

Base automatically changed from leafty/fix-db-update-user to main November 1, 2024 14:17
@leafty leafty force-pushed the leafty/fix-db-update-platform-config branch from 15945ce to 4550d80 Compare November 1, 2024 14:25
@coveralls
Copy link

coveralls commented Nov 1, 2024

Pull Request Test Coverage Report for Build 11664628683

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 15 of 15 (100.0%) changed or added relevant lines in 4 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.01%) to 90.863%

Files with Coverage Reduction New Missed Lines %
components/renku_data_services/storage/blueprints.py 1 93.18%
components/renku_data_services/crc/models.py 2 85.44%
Totals Coverage Status
Change from base Build 11664606374: 0.01%
Covered Lines: 11148
Relevant Lines: 12269

💛 - Coveralls

@leafty leafty marked this pull request as ready for review November 4, 2024 08:09
@leafty leafty requested a review from a team as a code owner November 4, 2024 08:09
@leafty leafty enabled auto-merge (squash) November 4, 2024 12:54
@leafty leafty merged commit 7b44f99 into main Nov 4, 2024
12 checks passed
@leafty leafty deleted the leafty/fix-db-update-platform-config branch November 4, 2024 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants