refactor: use typed patch instance for session updates #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
leafty
force-pushed
the
leafty/fix-db-update-platform-config
branch
from
15945ce
to
4550d80
Compare
…session # Conflicts: # components/renku_data_services/users/db.py
Pull Request Test Coverage Report for Build 11680883133Details
💛 - Coveralls |
Panaetius
reviewed
Nov 4, 2024
Panaetius
approved these changes
Nov 5, 2024
| return str(id) | ||
| def serialize_ulid(cls, value: Any) -> Any: | ||
| """Handle ULIDs.""" | ||
| if isinstance(value, ULID): |
There was a problem hiding this comment.
that's a nice way to handle it 👍 , we might want to add that for the other apispec_base.py's as well
There was a problem hiding this comment.
I was thinking that we should have a common apispec_base.py file because otherwise we have a lot of code fragmentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #485.
The session blueprint is also updated to use the
validated_json()method for API responses.