fix: apply suggestions from the PR review

SwissDataScienceCenter · Apr 14, 2020 · c1b8fac · c1b8fac
1 parent bdbf359
commit c1b8fac
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/helm-chart/renku-ui/templates/deployment.yaml b/helm-chart/renku-ui/templates/deployment.yaml
@@ -46,7 +46,7 @@ spec:
               value: {{ required "templateRepository.ref must be specified, e.g., master" .Values.templatesRepository.ref | quote }}
               {{- if .Values.maintenance }}
             - name: MAINTENANCE
-              value: {{ .Values.maintenance | default (printf "true") | quote }}
+              value: {{ .Values.maintenance | default (printf "false") | quote }}
               {{- end }}
           livenessProbe:
             httpGet:

diff --git a/helm-chart/renku-ui/values.yaml b/helm-chart/renku-ui/values.yaml
@@ -62,7 +62,8 @@ templatesRepository:
   url: https://github.com/SwissDataScienceCenter/renku-project-template
   ref: 0.1.9
 
-# any string here will enable the maintenance page and be added on it as an info
+# Any string here, other than 'false', will enable the maintenance page and be added on it as an info.
+# Setting 'true' will display a standard message embedded in maintenace page.
 maintenance: false
 
 sentry:

diff --git a/run-telepresence.sh b/run-telepresence.sh
@@ -75,8 +75,7 @@ tee > ./public/config.json << EOF
   "SENTRY_URL": "${SENTRY_URL}",
   "SENTRY_NAMESPACE": "${SENTRY_NAMESPACE}",
   "RENKU_TEMPLATES_URL": "https://github.com/SwissDataScienceCenter/renku-project-template",
-  "RENKU_TEMPLATES_REF": "master",
-  "MAINTENANCE": "true"
+  "RENKU_TEMPLATES_REF": "master"
 }
 EOF