perf: query 100 projects instead of 20 (#983)

Change the default per_page parameter from 20 to 100 when invoking the GET /projects endpoint from GitLab to prevent unnecessary queries.
SwissDataScienceCenter · Jul 20, 2020 · c6fced4 · c6fced4
1 parent 8792363
commit c6fced4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/api-client/project.js b/src/api-client/project.js
@@ -108,7 +108,7 @@ function addProjectMethods(client) {
   };
 
   client.getAllProjects = (extraParams = [],
-    { recursive = false, per_page = 20, page = 1, previousResults = [] } = {}
+    { recursive = false, per_page = 100, page = 1, previousResults = [] } = {}
   ) => {
     let headers = client.getBasicHeaders();
 

diff --git a/src/project/shared/Projects.state.js b/src/project/shared/Projects.state.js
@@ -54,15 +54,15 @@ class ProjectsCoordinator {
     if (this.model.get("featured.fetching")) return;
     // set status to fetching and invoke both APIs
     this.model.set("featured.fetching", true);
-    const promiseStarred = this.client.getProjects({ starred: true, order_by: "last_activity_at" })
+    const promiseStarred = this.client.getProjects({ starred: true, order_by: "last_activity_at", per_page: 100 })
       .then((projectResponse) => {
         const projects = projectResponse.data.map((project) => this._starredProjectMetadata(project));
         return projects;
       })
       .catch((error) => {
         this.model.set("starredProjects", []);
       });
-    const promiseMember = this.client.getAllProjects({ membership: true, order_by: "last_activity_at" })
+    const promiseMember = this.client.getAllProjects({ membership: true, order_by: "last_activity_at", per_page: 100 })
       .then((projectResponse) => {
         const projects = projectResponse.map((project) => this._starredProjectMetadata(project));
         return projects;