Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Looking logged in open tabs when a log out has been performed #1048

Closed
lorenzo-cavazzi opened this issue Sep 28, 2020 · 1 comment · Fixed by #1163
Closed

Looking logged in open tabs when a log out has been performed #1048

lorenzo-cavazzi opened this issue Sep 28, 2020 · 1 comment · Fixed by #1163
Assignees
Labels

Comments

@lorenzo-cavazzi
Copy link
Member

Description

The user still looks logged in when a log out has been performed in another tab. Even if it's not possible to get data for protected resources, the UX is very confusing because the user believes to still be logged in.
An especially confusing case is the interactive environment page because the anonymous login is triggered on a 404 response from /servers, showing the content of an anonymous user in a page for logged user.
E.G. on a public project, a user may have launched a few environments. On log out, those disappear but the anonymous login is triggered, therefore the API succed and the following responses are valid. The user thinks the environments were closed but in fact he is now interacting as an anonymous user and the previous environments are still running but non accessible until the login.
Furthermore, if the user try to start new environments, he won't be able to push to the repository since the proper autentication tokens are missing.

Reproduce

  • Open 2 tabs in https://renkulab.io/
  • Browse to a own project (possibly public) and start an interactive environment
  • Try to logout from the other tab, then go back to the previous one
@lorenzo-cavazzi lorenzo-cavazzi self-assigned this Sep 28, 2020
@lorenzo-cavazzi lorenzo-cavazzi added this to the sprint-2020-10-01 milestone Sep 28, 2020
@lorenzo-cavazzi
Copy link
Member Author

#874

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants