Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Project stats are not correct #1074

Closed
m-alisafaee opened this issue Oct 16, 2020 · 1 comment · Fixed by #1192
Closed

Project stats are not correct #1074

m-alisafaee opened this issue Oct 16, 2020 · 1 comment · Fixed by #1192
Assignees
@lorenzo-cavazzi
Labels
bug
Milestone
sprint-2020-12-04

Comments

@m-alisafaee
Copy link

Description

Project stats (Renku project page > Overview > Stats) are not correct when a project is modified. It seems that they will be eventually correct after couple of hours.

Reproduce

  1. Go to a project with some files in LFS: https://dev.renku.ch/projects/mohammad.alisafaee/lego-analytics/overview/stats
  2. Clone the project
  3. Go to the cloned project > Overview > Stats
  4. See that Storage stats are not correct (even after gitlab pipeline finishes)
@lorenzo-cavazzi
Copy link
Member

Thank you Mohammad for reporting this.
I investigated a bit and it seems that the stats from GitLab are not updated instantly. I get the same problem on the GitLab page.

Nevertheless, we don't query again for the stats when entering the stats tab, so we won't show the up-to-date stats anyway. This needs to be fixed.
I believe the logic on the Overview page navigation is broken. Clicking any tab (Description, Stats, Commits...) always triggers a query for the readme file content that is needed only for Description. Every tab should first refresh the resources it needs.

@ciyer ciyer added this to the sprint-2020-10-22 milestone Oct 21, 2020
@lorenzo-cavazzi lorenzo-cavazzi self-assigned this Jan 5, 2021
lorenzo-cavazzi added a commit that referenced this issue Jan 8, 2021
@lorenzo-cavazzi
fix: fetch and store project statistics
185207d 
* move statistics to project coordinator
* properly clean and refresh statistics when entering the project overview stats tab

fix #1074
@lorenzo-cavazzi lorenzo-cavazzi mentioned this issue Jan 8, 2021
Merged
lorenzo-cavazzi added a commit that referenced this issue Jan 12, 2021
@lorenzo-cavazzi
fix: fetch and store project statistics (#1192)
66ee302 
* move statistics data to global store and fetch stats in the new project coordinator
* fetch or refresh only the required resources when browsing project overview tabs

fix #1074
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lorenzo-cavazzi lorenzo-cavazzi

Labels
bug
Projects
None yet
Milestone
sprint-2020-12-04
Development

Successfully merging a pull request may close this issue.

fix projects overview tabs SwissDataScienceCenter/renku-ui
3 participants
@ciyer @lorenzo-cavazzi @m-alisafaee