Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slow CSV File Rendering #1147

Closed
3 tasks done
ciyer opened this issue Nov 30, 2020 · 0 comments · Fixed by #1186
Closed
3 tasks done

Slow CSV File Rendering #1147

ciyer opened this issue Nov 30, 2020 · 0 comments · Fixed by #1186
Assignees
@lorenzo-cavazzi
Labels
bug
Milestone
sprint-2020-12-04

Comments

@ciyer
Copy link
Contributor

ciyer commented Nov 30, 2020 •
edited by lorenzo-cavazzi
Loading

Description

Viewing this file in RenkuLab causes the UI to grind to a halt.

https://dev.renku.ch/projects/cramakri/my-test-project/files/blob/data/rendering-probolem/data_original_aziza_HIVIncidence_per1000_15_49.csv

We should investigate why because the file is not especially large.

Solution

  • Find out why this file causes problems
  • Fix the problem
  • Also, add limits to the size of files we display in the RenkuLab UI. We do not want to show very large files in the UI.
@ciyer ciyer added the bug label Nov 30, 2020
@ciyer ciyer added this to the sprint-2020-12-04 milestone Nov 30, 2020
lorenzo-cavazzi added a commit that referenced this issue Dec 23, 2020
@lorenzo-cavazzi
feat: improve file preview
8ee157d 
* customize message for git LFS files
* prevent previewing very big files
* show warning with alternative options for big files likely to take a long time for the preview

fix #1147
@lorenzo-cavazzi lorenzo-cavazzi self-assigned this Dec 23, 2020
@lorenzo-cavazzi lorenzo-cavazzi mentioned this issue Dec 23, 2020
Merged
lorenzo-cavazzi added a commit that referenced this issue Jan 5, 2021
@lorenzo-cavazzi
feat: improve and speed up file preview (#1186)
99726cf 
* preview csv files as plain text to prevent useless formatting slowdown
* customize message for git LFS files
* change behaviour on big files: show warning with alternative options, or prevent preview completely for very big files. The thresholds are exposed to the values file.

fix #1147
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lorenzo-cavazzi lorenzo-cavazzi

Labels
bug
Projects
None yet
Milestone
sprint-2020-12-04
Development

Successfully merging a pull request may close this issue.

speed up csv preview and improve lfs and big files SwissDataScienceCenter/renku-ui
2 participants
@ciyer @lorenzo-cavazzi