Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renku config options don't appear properly on the UI #1306

Closed
gavin-k-lee opened this issue Apr 12, 2021 · 1 comment · Fixed by #1308
Closed

renku config options don't appear properly on the UI #1306

gavin-k-lee opened this issue Apr 12, 2021 · 1 comment · Fixed by #1308
Assignees
@lorenzo-cavazzi
Labels
bug
Milestone
0.11.10

Comments

@gavin-k-lee
Copy link

gavin-k-lee commented Apr 12, 2021 •
edited
Loading

Description

In the file ./renku/renku.ini there are options for renku configs. For example, setting the default_url = "/vnc" will direct the 'connect' button to the vnc:

image

However, other options are not picked up. For example, after running renku config set interactive.mem_request "4G" and renku config set interactive.cpu_request "1", these defaults are not selected in the UI:

image

Reproduce

  1. Create an empty project and run renku config set interactive.mem_request "4G" and renku config set interactive.cpu_request "1" from the terminal
  2. Wait for the image to build and go to the environments page
  3. See that the defaults are not shown.
@lorenzo-cavazzi
Copy link
Member

Thank you for reporting that!
I fear something changed here SwissDataScienceCenter/renku-python#1834 and the UI doesn't support this change yet. Fixing it should be easy.

lorenzo-cavazzi added a commit that referenced this issue Apr 12, 2021
@lorenzo-cavazzi
fix: update environments section name
6fc2ff7 
fix #1306
@lorenzo-cavazzi lorenzo-cavazzi mentioned this issue Apr 12, 2021
Merged
@lorenzo-cavazzi lorenzo-cavazzi self-assigned this Apr 12, 2021
@lorenzo-cavazzi lorenzo-cavazzi added this to the 0.11.10 milestone Apr 12, 2021
lorenzo-cavazzi added a commit that referenced this issue Apr 13, 2021
@lorenzo-cavazzi
fix: support new environments section name (#1308)
8cd23f7 
Support the new section name for environments variables introduced
in version 0.14.1 by renku-python, keeping backward compatibility.
SwissDataScienceCenter/renku-python/releases/tag/v0.14.1

fix #1306
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lorenzo-cavazzi lorenzo-cavazzi

Labels
bug
Projects
None yet
Milestone
0.11.10
Development

Successfully merging a pull request may close this issue.

fix: update environments section name SwissDataScienceCenter/renku-ui
2 participants
@gavin-k-lee @lorenzo-cavazzi