Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automatically expand session options when base image is not available #1679

Closed
lorenzo-cavazzi opened this issue Feb 3, 2022 · 0 comments · Fixed by #1730
Closed

Automatically expand session options when base image is not available #1679

lorenzo-cavazzi opened this issue Feb 3, 2022 · 0 comments · Fixed by #1730

Comments

@lorenzo-cavazzi
Copy link
Member

Trying to start a session from the quick-start button on the top right of a project page fails for projects with a faulty image (E.G. https://dev.renku.ch/projects/lorenzo.cavazzi.tech/1-0-4-project-without-jobs ).
The feedback, in that case, is clear, with a warning message and the advanced options automatically expanded.

Screenshot_20220203_163837

However, clicking on the "New session" button from the "Sessions" tab shows a 'mild' feedback (as in the next screen), pushing the user to click on "Start with base image" instead of trying to (re)run the job or build the pipeline.

Screenshot_20220203_163534

We should expand the advanced options automatically in that case.
No extra banner is needed since the user still hasn't started any session and nothing failed yet.
lorenzo-cavazzi added a commit that referenced this issue Mar 14, 2022
@lorenzo-cavazzi
feat(client): improve starting new sessions
cc04819 
* overhaul images and ci checks
* fix glitches with branches and commits
* uniform behavior on autostart failures

fix #1408, #1679
@lorenzo-cavazzi lorenzo-cavazzi mentioned this issue Mar 14, 2022
Merged
lorenzo-cavazzi added a commit that referenced this issue Mar 15, 2022
@lorenzo-cavazzi
feat(client): improve starting new sessions
5f36ac1 
* overhaul images and ci checks
* fix glitches with branches and commits
* uniform behavior on autostart failures

fix #1408, #1679
lorenzo-cavazzi added a commit that referenced this issue Mar 17, 2022
@lorenzo-cavazzi
feat(client): improve starting new sessions (#1730)
6d25881 
* overhaul images and ci checks
* fix glitches with branches and commits
* uniform behavior on autostart failures

fix #1408, #1679
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(client): improve starting new sessions SwissDataScienceCenter/renku-ui
1 participant
@lorenzo-cavazzi