Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shape Up #1 - Fixes and changes to fourth prototype #2082

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

lorenzo-cavazzi
Copy link
Member

@lorenzo-cavazzi lorenzo-cavazzi commented Oct 19, 2022

Changes to browser components:

  • Remove "steps" from composite workflow browser executions row
  • Add the renku rerun <workflow> command to the details view with copy/paste
  • change interaction on the browser elements: open on element click, collapse on arrow click
  • Add auto-scroll to the top of the details section when clicking on a new workflow (it requires a project with many workflows)

/deploy renku-core=workflow-ui-feature-branch #persist

@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-ui-2082 October 19, 2022 08:57 Inactive
@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ui-2082.dev.renku.ch

@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-ui-2082 October 19, 2022 09:34 Inactive
Base automatically changed from shapeup1-prototype4 to shapeup1-workflows-ui October 19, 2022 15:35
@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-ui-2082 October 19, 2022 16:11 Inactive
@lorenzo-cavazzi lorenzo-cavazzi temporarily deployed to renku-ci-ui-2082 October 20, 2022 06:56 Inactive
@lorenzo-cavazzi lorenzo-cavazzi marked this pull request as ready for review October 20, 2022 08:50
@lorenzo-cavazzi lorenzo-cavazzi requested a review from a team as a code owner October 20, 2022 08:50
Copy link
Contributor

@andre-code andre-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 the code looks good and everything works as expected!

@lorenzo-cavazzi lorenzo-cavazzi merged commit fd501eb into shapeup1-workflows-ui Oct 20, 2022
@lorenzo-cavazzi lorenzo-cavazzi deleted the shapeup1-prototype4-fixes branch October 20, 2022 13:04
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants